Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated sync GETS even when no change in the server #1121

Closed
mahalakshme opened this issue Oct 4, 2023 · 0 comments
Closed

Repeated sync GETS even when no change in the server #1121

mahalakshme opened this issue Oct 4, 2023 · 0 comments

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Oct 4, 2023

Steps to reproduce:

  • env: prerelease, user_id: nupoork@apfodisha or utkarsh@lahi
  • after login sync, sync again

Image

  • server call are made as mentioned above.
  • now sync again
  • similar server calls to groupPrivileges, programEncounters, enrolment, etc will be made which is unnecessary.

Acceptance criteria:

  • Already synced data to mobile app, should not be got again from server for all entities.

Analysis details:

The above is because for some calls sync was retrieving data equal to lastModifiedDateTime as well.

Impact:

Considering everyday around 1900 syncs are made, 15 unwanted calls per sync translates to around 30k unwanted calls/day reducing load on server and like 2s sync time save.

@mahalakshme mahalakshme converted this from a draft issue Oct 4, 2023
@mahalakshme mahalakshme changed the title Update EntitySyncStatus loadedSince with synctime instead of lastModifiedDateTime Repeated sync GETS even when no change in the server Oct 4, 2023
@vinayvenu vinayvenu moved this from In Analysis to Done in Avni Product Oct 16, 2023
@mahalakshme mahalakshme moved this from Done to New Issues in Avni Product Oct 16, 2023
@mahalakshme mahalakshme moved this from New Issues to Triaging analysis in Avni Product Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triaging analysis
Development

No branches or pull requests

2 participants