Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to generate apks for different flavors via circle-ci for live stage #1096

Closed
mahalakshme opened this issue Sep 15, 2023 · 6 comments
Closed

Add ability to generate apks for different flavors via circle-ci for live stage #1096

mahalakshme opened this issue Sep 15, 2023 · 6 comments
Assignees
@1t5j0y

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Sep 15, 2023 •
edited by 1t5j0y
Loading

Currently apk generated in the live stage is not signed with the right keystore. This causes confusion when for some reason this apk need to be shared with external client or need to be used for internal testing.

Analysis notes - options:

  1. Try using make release_prod_universal_without_clean instead of using bundletool.jar to generate universal apk from bundle
  2. or use the right parameters for keystore, key password and keystore password

Additionally, deploy platform translations while building live stage.
@mahalakshme mahalakshme converted this from a draft issue Sep 15, 2023
@mahalakshme mahalakshme changed the title Add ability to generate apks for different flavors via circle-ci Add ability to generate apks for different flavors via circle-ci for live stage Sep 17, 2023
mahalakshme added a commit that referenced this issue Sep 17, 2023
@mahalakshme
#1096 | Generate prod universal apk
427f47b
@1t5j0y
Copy link
Contributor

1t5j0y commented Sep 18, 2023

Related: #1028

@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Sep 18, 2023
@1t5j0y 1t5j0y self-assigned this Sep 18, 2023
1t5j0y added a commit that referenced this issue Sep 18, 2023
@1t5j0y
#1028, #1096 | Standardise keystore naming and setup
73fb58a 
- helps with generating flavor specific prod APKs
1t5j0y added a commit that referenced this issue Sep 18, 2023
@1t5j0y
#1028, #1096 | Escape $ while determining key env variable names from…
3d26ddf 
… flavor
1t5j0y added a commit that referenced this issue Sep 18, 2023
@1t5j0y
#1028, #1096 | Try alternate approach to determine key specific env v…
b4f005e 
…ars from flavor
1t5j0y added a commit that referenced this issue Sep 18, 2023
@1t5j0y
#1028, #1096 | Try alternate approach to determine key specific env v…
0275e84 
…ars from flavor
1t5j0y added a commit that referenced this issue Sep 18, 2023
@1t5j0y
#1028, #1096 | Try with lower case flavor name in key specific env vars
23d7e57
1t5j0y added a commit that referenced this issue Sep 18, 2023
@1t5j0y
#1028, #1096 | Use lower case flavor name for key specific env vars f…
e0acbe6 
…or all flavors
@1t5j0y
Copy link
Contributor

1t5j0y commented Sep 18, 2023 •
edited
Loading

Renamed keystore files to <flavor>-release-key.keystore
Standardised keystore password env var to <flavor>_KEYSTORE_PASSWORD (i.e. lfe_KEYSTORE_PASSWORD, lfeTeachNagaland_KEYSTORE_PASSWORD, generic_KEYSTORE_PASSWORD etc)
Standardised key password env var to <flavor>_KEY_PASSWORD
Added env var for key alias with the format <flavor>_KEY_ALIAS

1t5j0y added a commit that referenced this issue Sep 18, 2023
@1t5j0y
#1028, #1096 | Fix flavor_folder_uppercase_path
c336535
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Sep 18, 2023
@petmongrels
Copy link
Contributor

petmongrels commented Sep 18, 2023 •
edited
Loading

does this need update - https://avni.readme.io/docs/release-process-for-the-cloud#circleci-build

also this - https://avni.readme.io/docs/flavouring-avni#steps-to-do-to-get-build-via-circle-ci

objective - can I follow these steps and generate my own apk?

@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Sep 18, 2023
@petmongrels petmongrels moved this from In Code Review to Code Review with Comments in Avni Product Sep 18, 2023
@1t5j0y 1t5j0y moved this from Code Review with Comments to In Progress in Avni Product Sep 19, 2023
@1t5j0y
Copy link
Contributor

1t5j0y commented Sep 19, 2023 •
edited
Loading

No changes to the steps required for building apks via circleci. Updated both the above docs for changes in steps for building prod APK locally.

@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Sep 19, 2023
@mahalakshme mahalakshme moved this from Code Review Ready to In Code Review in Avni Product Sep 19, 2023
@mahalakshme mahalakshme moved this from In Code Review to QA Ready in Avni Product Sep 19, 2023
1t5j0y pushed a commit that referenced this issue Sep 19, 2023
@mahalakshme @1t5j0y
#1096 | Generate prod universal apk
59a6d21 
(cherry picked from commit 427f47b)
1t5j0y added a commit that referenced this issue Sep 19, 2023
@1t5j0y
#1028, #1096 | Standardise keystore naming and setup
2c21491 
- helps with generating flavor specific prod APKs

(cherry picked from commit 73fb58a)
1t5j0y added a commit that referenced this issue Sep 19, 2023
@1t5j0y
#1028, #1096 | Escape $ while determining key env variable names from…
fa829e3 
… flavor

(cherry picked from commit 3d26ddf)
1t5j0y added a commit that referenced this issue Sep 19, 2023
@1t5j0y
#1028, #1096 | Try alternate approach to determine key specific env v…
3dfda98 
…ars from flavor

(cherry picked from commit b4f005e)
1t5j0y added a commit that referenced this issue Sep 19, 2023
@1t5j0y
#1028, #1096 | Try alternate approach to determine key specific env v…
8a2934b 
…ars from flavor

(cherry picked from commit 0275e84)
1t5j0y added a commit that referenced this issue Sep 19, 2023
@1t5j0y
#1028, #1096 | Try with lower case flavor name in key specific env vars
99e8702 
(cherry picked from commit 23d7e57)
1t5j0y added a commit that referenced this issue Sep 19, 2023
@1t5j0y
#1028, #1096 | Use lower case flavor name for key specific env vars f…
08f48c2 
…or all flavors

(cherry picked from commit e0acbe6)
1t5j0y added a commit that referenced this issue Sep 19, 2023
@1t5j0y
#1028, #1096 | Fix flavor_folder_uppercase_path
e960c53 
(cherry picked from commit c336535)
@mahalakshme mahalakshme moved this from QA Ready to In QA in Avni Product Sep 19, 2023
@mahalakshme mahalakshme moved this from In QA to QA Ready in Avni Product Sep 19, 2023
@1t5j0y 1t5j0y mentioned this issue Sep 21, 2023
Closed
@mahalakshme
Copy link
Contributor Author

@1t5j0y I think upload translations not done for live stage. Just realised recently.

@mahalakshme mahalakshme moved this from QA Ready to Code Review with Comments in Avni Product Sep 22, 2023
@1t5j0y 1t5j0y moved this from Code Review with Comments to In Progress in Avni Product Sep 22, 2023
1t5j0y added a commit that referenced this issue Sep 22, 2023
@1t5j0y
#1096 | Deploy translations in circleci release_android_live job
73b02bf
@1t5j0y
Copy link
Contributor

1t5j0y commented Sep 22, 2023

Added into scope of this card and implemented.

@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Sep 22, 2023
@petmongrels petmongrels moved this from Code Review Ready to Done in Avni Product Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1t5j0y 1t5j0y

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@petmongrels @vinayvenu @mahalakshme @1t5j0y