Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier assignment not working as expected when an intermediate one is moved out of catchment #1092

Closed
mahalakshme opened this issue Sep 8, 2023 · 3 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Sep 8, 2023

Steps to reproduce:

  • For user say, maha@jscsuat, Anuppur catchment, create individuals test123, test456, test789 and enrol them to sickle cell
  • As another user, say suhas@jscsuat, Anuppur enlarged catchment(Anuppur + some village say, Pindari which doesn't belong to Anuppur), change the address of test456 to Pindari.
  • As maha@jscsuat sync, and then create a individual and enrol them in sickle cell. Enrolment id of test456 will appear. But the next enrolment id of test789 should appear.

Description in short:

Actual: When a subject is migrated out of a catchment, enrolment_identifier of the subject is listed again when a new program enrolment is attempted.

Expected: The enrolment_identifier of the subject moved out of catchment should not be used, since the subject still exists. Hence the next identifier from the last used identifier should be used.

@mahalakshme mahalakshme converted this from a draft issue Sep 8, 2023
@mahalakshme mahalakshme changed the title Identifier assignment not working as expected when an intermediate one is unassigned Identifier assignment not working as expected when an intermediate one is moved out of catchment Sep 8, 2023
@mahalakshme mahalakshme moved this from Ready to Analysis Complete in Avni Product Oct 5, 2023
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Oct 13, 2023
@vinayvenu vinayvenu moved this from Ready to In Progress in Avni Product Oct 17, 2023
@vinayvenu vinayvenu self-assigned this Oct 17, 2023
vinayvenu added a commit to avniproject/avni-models that referenced this issue Oct 17, 2023
@vinayvenu vinayvenu moved this from In Progress to Code Review Ready in Avni Product Oct 18, 2023
@vinayvenu
Copy link
Member

Tests required

  1. Scenario mentioned in steps to reproduce
  2. With fast sync setup (verify the database)
  3. Upgrade

@vinayvenu
Copy link
Member

Change - introducing a variable that mentions if an identifier has been used. Since the individual cannot be relied upon since it goes away, but the identifier stays in the db, we need to keep this state elsewhere.

@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Oct 18, 2023
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Oct 18, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Oct 20, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Oct 20, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Oct 30, 2023
@mahalakshme
Copy link
Contributor Author

mahalakshme commented Oct 30, 2023

@vinayvenu what do we do for already existing duplicates? Since we dont have more than 20 duplicates, I think we can let the implementation team to decide on handling it by communicating as necessary with the client.

@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Oct 30, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Oct 30, 2023
@github-project-automation github-project-automation bot moved this from In QA to Done in Avni Product Oct 31, 2023
@vinayvenu vinayvenu reopened this Oct 31, 2023
@github-project-automation github-project-automation bot moved this from Done to Triaged in Avni Product Oct 31, 2023
@vinayvenu vinayvenu moved this from Triaged to In QA in Avni Product Oct 31, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Nov 2, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 3, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Nov 3, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 6, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Nov 6, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 7, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants