Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--pull does not propagate to docker build command #64

Open
staffanf opened this issue Aug 19, 2021 · 0 comments
Open

--pull does not propagate to docker build command #64

staffanf opened this issue Aug 19, 2021 · 0 comments

Comments

@staffanf
Copy link

Hi @avirshup!

I'm using DockerMake with the --pull option thinking that this would make it pull the base image manifest every time.
After looking at the code, I realize that the --pull option is not sent to the docker build command, it only affects sourceimages.
I.e. --pull option does not pull new FROM images if they have changed, this make it hard for us to have updated base images.

Changing line 113 in builds.py to step.build(client, usecache=usecache, pull=True) fixes this for me.

Is this is bug or is there a reason pull not being propagated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant