Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any option to signal that the binary is inside a folder and not the single file of the fetched url? #38

Closed
daviddias opened this issue Sep 12, 2019 · 1 comment · May be fixed by #39
Closed

Comments

@daviddias
Copy link

daviddias commented Sep 12, 2019

Going through the code, my understanding was that it could be done by putting in the config:

binaries: [
  "folder-name/myapp-cli"
],

But then I get an error:

Error: ENOENT: no such file or directory, open 'bin/go-ipfs/ipfs'

As it expects that the full folder to be moved to the bin.

Thanks in advance :)


Update: Some notes fro the digging

https://github.com/avh4/binwrap/blob/master/index.js#L8-L10 uses the binary name to check if it is already present on the bin folder

https://github.com/avh4/binwrap/blob/master/install.js#L22 uses the unpacked folder + binary name to find the binary. However, when a binary is one or more levels deep, it fails to find it.

https://github.com/avh4/binwrap/blob/master/bin/binwrap-install#L16 line that needs to be aware if the bin is somewhere else within the directory (or maybe here https://github.com/avh4/binwrap/blob/master/bin/binwrap-install#L16)

@avh4
Copy link
Owner

avh4 commented Nov 15, 2019

As noted in #39 (comment), I think the ideal fix for this would be to make folder names in binaries work as originally expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants