Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on request #25

Open
avh4 opened this issue Apr 26, 2019 · 4 comments
Open

Remove dependency on request #25

avh4 opened this issue Apr 26, 2019 · 4 comments

Comments

@avh4
Copy link
Owner

avh4 commented Apr 26, 2019

Assuming this can be done safely (that there aren't notable features we lose by using nodejs APIs directly), this should be done to remove transitive dependencies.

@harrysarson
Copy link

Does the @rtfeldman's pull request #19 not do this?

@avh4 avh4 removed the help wanted label Apr 27, 2019
@avh4
Copy link
Owner Author

avh4 commented Apr 27, 2019

Ah, yes it does, thanks!

@avh4
Copy link
Owner Author

avh4 commented Jul 21, 2019

Adding back "help wanted", since #19 needs to be rebased and have the failing tests fixed.

@avh4 avh4 changed the title Remove dependency on request/request-promise Remove dependency on request Feb 4, 2021
@sporto
Copy link

sporto commented Nov 24, 2022

This dependecy has a critical vulnerability, which is problem for security audits.

request depends on form-data 2.3.3
https://github.com/request/request/blob/master/package.json#L36

Which depends on json-schema 0.2.3

json-schema 0.2.3 has a critical vulnerability:
GHSA-896r-f27r-55mw

It would be great if this dependecy could be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants