chore: basic CI #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested review from
a team,
darioush,
ceyonur and
michaelkaplan13
and removed request for
a team
| @@ -108,7 +108,8 @@ func (*Extras[C, R]) getter() (g ExtraPayloadGetter[C, R]) { return } | |||
|
|
|||
| // mustBeStruct panics if `T` isn't a struct. | |||
| func mustBeStruct[T any]() { | |||
| if k := reflect.TypeFor[T]().Kind(); k != reflect.Struct { | |||
| var x T | |||
| if k := reflect.TypeOf(x).Kind(); k != reflect.Struct { | |||
There was a problem hiding this comment.
For my own understanding, why is TypeOf preferred to TypeFor here?
There was a problem hiding this comment.
TypeFor was only introduced in 1.22 and because we're on an old geth upstream it's on an older Go version.
michaelkaplan13
approved these changes
Sep 10, 2024
marun
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Move fast but don't break things.
How this works
Action to run
go test -shortafter filtering for flaky upstream tests. I've opened #10 to investigate these. I've also updated thelibevmbranch protection to require that the job passes.How this was tested
Through the horrible experience that is testing and re-testing Github Actions 🤦