node local PoC #138
sukantoraymondAnnotations
10 errors and 7 warnings
|
Lint:
pkg/subnet/deploy_status.go#L1
: # github.com/ava-labs/avalanche-cli/pkg/subnet [github.com/ava-labs/avalanche-cli/pkg/subnet.test]
|
|
Lint:
pkg/subnet/local_test.go#L194
cannot use c (variable of type *mocks.Client) as "github.com/ava-labs/avalanche-network-runner/client".Client value in return statement: *mocks.Client does not implement "github.com/ava-labs/avalanche-network-runner/client".Client (wrong type for method RemoveSnapshot)
|
|
Lint:
pkg/node/local.go#L299
Error return value is not checked (errcheck)
|
|
Lint:
pkg/node/local.go#L396
Error return value is not checked (errcheck)
|
|
Lint:
cmd/blockchaincmd/add_validator.go#L195
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
Lint:
cmd/blockchaincmd/deploy.go#L492
elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
|
|
Lint:
cmd/nodecmd/list.go#L59
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
Lint:
pkg/node/helper.go#L8
File is not `gofumpt`-ed (gofumpt)
|
|
Lint:
pkg/node/helper.go#L12
File is not `gofumpt`-ed (gofumpt)
|
|
Lint:
pkg/node/local.go#L6
File is not `gofumpt`-ed (gofumpt)
|
|
Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint:
pkg/node/helper.go#L394
empty-lines: extra empty line at the end of a block (revive)
|
|
Lint:
cmd/blockchaincmd/remove_validator.go#L187
unused-parameter: parameter 'validationID' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
cmd/blockchaincmd/remove_validator.go#L193
unused-parameter: parameter 'nodeID' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
cmd/blockchaincmd/remove_validator.go#L198
unused-parameter: parameter 'validationID' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
cmd/blockchaincmd/add_validator.go#L148
unused-parameter: parameter 'kc' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
cmd/blockchaincmd/add_validator.go#L264
unused-parameter: parameter 'subnetID' seems to be unused, consider removing or renaming it as _ (revive)
|