Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoProperties : fix isClosedGop method #148

Open
cchampet opened this issue Nov 6, 2015 · 1 comment
Open

VideoProperties : fix isClosedGop method #148

cchampet opened this issue Nov 6, 2015 · 1 comment
Labels
bug feature

Comments

@cchampet
Copy link
Member

cchampet commented Nov 6, 2015

Issue by valnoel
Monday Jan 12, 2015 at 12:27 GMT
Originally opened as mikrosimage#39

Need a patch in FFmpeg.
@cchampet
Copy link
Member Author

cchampet commented Nov 6, 2015

Comment by cchampet
Wednesday Apr 01, 2015 at 14:00 GMT

Maybe not a patch...
FFmpeg's mpegvideo decoder detects the correct gop (closed or not) here:
https://github.com/FFmpeg/FFmpeg/blob/1932f7e2eee07e4a50e014a625dca79a9f9dba7a/libavcodec/mpeg12dec.c#L2386
But the information in "hidden" in a sub AVOptions-enabled children of AVCodecContext. This must be detect in avTranscoder here:
https://github.com/mikrosimage/avTranscoder/blob/develop/src/AvTranscoder/codec/ICodec.cpp#L162
But we don't get it... Maybe we need to use:
https://github.com/FFmpeg/FFmpeg/blob/1932f7e2eee07e4a50e014a625dca79a9f9dba7a/libavutil/opt.h#L685
https://github.com/FFmpeg/FFmpeg/blob/1932f7e2eee07e4a50e014a625dca79a9f9dba7a/libavutil/opt.h#L693

cchampet pushed a commit to cchampet/avTranscoder that referenced this issue Nov 6, 2015
@valnoel
Merge pull request avTranscoder#148 from cchampet/ressource_addPreset…
5633b19 
…sh264

Add presets h264 low quality/high quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cchampet