Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scenario_simulator_v2_adapter): remove invalid CHANGELOG.rst file #9501

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 27, 2024

Description

A copy of the CHANGELOG.rst file for diagnostic_converter was added in #9180

Its version and package name don't match the data in package.xml. This is breaking builds in the buildfarm (see https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/12031082816/job/33539936241?pr=105)

This PR simply removes that file.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve self-assigned this Nov 27, 2024
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 27, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Nov 27, 2024
@esteve esteve requested a review from xmfcx November 27, 2024 11:25
Copy link

github-actions bot commented Nov 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.53%. Comparing base (35048a9) to head (3f5cc47).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ssing_time_checker/src/processing_time_checker.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9501      +/-   ##
==========================================
- Coverage   29.53%   29.53%   -0.01%     
==========================================
  Files        1439     1439              
  Lines      108533   108535       +2     
  Branches    41507    41502       -5     
==========================================
  Hits        32053    32053              
- Misses      73361    73363       +2     
  Partials     3119     3119              
Flag Coverage Δ *Carryforward flag
differential 1.91% <0.00%> (?)
total 29.53% <ø> (+<0.01%) ⬆️ Carriedforward from 35048a9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant