fix(learning_based_vehicle_model): fix clang-diagnostic-delete-abstra…

…ct-non-virtual-dtor Signed-off-by: Y.Hisaki <[email protected]>
autowarefoundation · Nov 28, 2024 · 4833b74 · 4833b74
1 parent c4608ad
commit 4833b74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.../learning_based_vehicle_model/include/learning_based_vehicle_model/submodel_interface.hpp b/.../learning_based_vehicle_model/include/learning_based_vehicle_model/submodel_interface.hpp
@@ -20,6 +20,8 @@
 class SubModelInterface
 {
 public:
+  virtual ~SubModelInterface() = default;
+
   /**
    * @brief set time step of the model
    * @param [in] dt time step

diff --git a/simulator/learning_based_vehicle_model/src/interconnected_model.cpp b/simulator/learning_based_vehicle_model/src/interconnected_model.cpp
@@ -75,8 +75,7 @@ void InterconnectedModel::addSubmodel(
   std::tuple<std::string, std::string, std::string> submodel_desc)
 {
   const auto [lib_path, param_path, class_name] = submodel_desc;
-  auto new_model = new SimplePyModel(lib_path, param_path, class_name);
-  submodels.push_back(std::unique_ptr<SimplePyModel>(new_model));
+  submodels.emplace_back(std::make_unique<SimplePyModel>(lib_path, param_path, class_name));
 }
 
 void InterconnectedModel::initState(std::vector<double> new_state)