AppIconExtractor not accepting wildcard despite help text indicating so

[sidbena]

Hello!

It seems that com.github.haircut.processors/AppIconExtractor doesn't support wildcarding, despite the help text indicating it should.

Excerpt from Slack conversation:

16:30 Tiwie 🍀
Hey! I'm trying to use the com.github.haircut.processors/AppIconExtractor processor, and it works if I supply the exact name of a relevant app, but as soon as the path includes a wildcard (and/or dmg), I start getting errors in the form of the processor not being able to determine an app icon for path /this/temp/path/*.app. Has anyone run into similar issues?

Traceback (most recent call last):
  File "/Library/AutoPkg/autopkglib/__init__.py", line 873, in process
    self.env = processor.process()
  File "/Library/AutoPkg/autopkglib/__init__.py", line 656, in process
    self.main()
  File "/Volumes/AutoPkg/RecipeRepos/com.github.autopkg.haircut-recipes/Processors/AppIconExtractor.py", line 350, in main
    raise ProcessorError(
autopkglib.ProcessorError: Unable to determine app icon path for app at /private/tmp/dmg.9rs0wU/*.app.
  File "/Library/AutoPkg/autopkglib/__init__.py", line 873, in process
    self.env = processor.process()
Unable to determine app icon path for app at /private/tmp/dmg.9rs0wU/*.app.

16:32
The processor should, according to its own variable description, support globbing.

"source_app": {
            "required": True,
            "description": "Path to the .app from which to extract an icon. "
            "Can point to a path inside a .dmg which will be mounted. This "
            "path may also contain basic globbing characters such as the "
            "wildcard '\*', but only the first result will be returned.",
        },

(edited)

16:50 nick.mcspadden :metafb:
Do you have a recipe you can reproduce this on?

16:50
Could be a bug

16:52
macmule :macadminsorg:
doesn't look like the processor does any wildcard globbing.. so might not work with wildcard paths... that source_app text seems like it's been copied

16:53
https://github.com/autopkg/autopkg/blob/master/Code/autopkglib/PkgCopier.py#L31C5-L39

17:21 nick.mcspadden :metafb:
Lol hilarious

17:21
Please file an issue for that

So, here I am creating an issue for that :)