Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add different Severity levels to issues #8

Open
oheyadam opened this issue Nov 14, 2022 · 0 comments
Open

[Feature Request] Add different Severity levels to issues #8

oheyadam opened this issue Nov 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@oheyadam
Copy link
Contributor

Right now, the plugin treats all issues equally, which means we can't add issues that should be surfaced as warnings instead of errors.

My current thinking is to create a Severity enum that gets added as a required field to the Issue sealed type. Seeing as some best practices can have use-cases where they don't necessarily apply, and in the spirit of treating them as guidelines as opposed to strict rules, maybe that severity should have a default value of Warning, and issue authors can override that when contributing new ones.

The ConfigurableLogger class would also need to be made aware of this change, and maybe the surfaced warning messages would need to be slightly reworded to reflect this severity level and make users aware of the fact that they can add specific issues to their baseline given that they have appropriate reasons for breaking tradition at call sites where a guideline doesn't apply. Maybe this is a slippery slope though? I don't know.

@autonomousapps autonomousapps added the enhancement New feature or request label Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants