Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: implement flag for spanner #2210

Merged
merged 1 commit into from
Jan 23, 2025
Merged

bug fix: implement flag for spanner #2210

merged 1 commit into from
Jan 23, 2025
+17 −7

Conversation

kartikaysaxena
Copy link
Contributor

Fixes #2089 implemented datastore-prometheus-metrics for spanner, tested with a spanner instance.

P.S. OpenTelemetry Instrumentation is still a work in progress

@kartikaysaxena kartikaysaxena requested a review from a team as a code owner January 22, 2025 08:27
@github-actions github-actions bot added area/CLI Affects the command line area/datastore Affects the storage system labels Jan 22, 2025
vroldanbet
vroldanbet reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, can you please check this defaults to true to make sure clusters already running don't loose visibility over their Spanner?

@kartikaysaxena
Copy link
Contributor Author

This makes sense, can you please check this defaults to true to make sure clusters already running don't loose visibility over their Spanner?

Spanner inherits it from DefaultDatastoreConfig if not specified which defaults to be true in this case
https://github.com/authzed/spicedb/blob/main/pkg/cmd/datastore/datastore.go#L305

vroldanbet
vroldanbet approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution.

On a side note, we encourage you to drop on our discord channel to discuss in case you want to contribute further, as for some complex issues it is better to first discuss design before jumping right away into the code 🙏🏻

@tstirrat15 tstirrat15 added this pull request to the merge queue Jan 23, 2025
@tstirrat15 tstirrat15 removed this pull request from the merge queue due to a manual request Jan 23, 2025
@tstirrat15 tstirrat15 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into authzed:main with commit 20d90b6 Jan 23, 2025
39 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/CLI Affects the command line area/datastore Affects the storage system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datastore-prometheus-metrics flag not implemented for Spanner
3 participants
@kartikaysaxena @vroldanbet @tstirrat15