Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Issue with deep dependency "hoek" #81

Open
kamesh95 opened this issue Apr 24, 2018 · 1 comment
Open

Security Issue with deep dependency "hoek" #81

kamesh95 opened this issue Apr 24, 2018 · 1 comment

Comments

@kamesh95
Copy link

OWASP Security check fails on this passport-wsfed-saml2 module as there is a deep dependency hoek v0.9.1 that's vulnerable to a Prototype pollution attack - https://nodesecurity.io/advisories/566. The issue was however patched in the later versions but it still exists in passport-wsfed-saml2 because of old cryptiles module. The dependency breakdown is - (cryptiles -> boom -> hoek). Cryptiles is dependent on boom which in turn is dependent on hoek. The boom package has upgraded hoek and also the cryptiles package has upgraded boom in turn but passport-wsfed-saml2 is dependent on old cryptiles version. Please upgrade the cryptiles module version so that the vulnerability is resolved. Thanks.

@kamesh95
Copy link
Author

@mikeops Can we upgrade cryptiles without breaking things? Do you know the reason why Travis build failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants