On a strange and undocumented behavior of the homeRealm strategy option

[ramtob]

The value of the homeRealm option is sent to the identity provider as a parameter with the name whr (&whr=value). If we omit the homeRealm option, we would expect that the whr parameter will not be sent. But in fact it is sent, with an empty value (&whr=). This empty-value parameter actually caused a bug, in an ADFS environment I was working at (that’s how I got to know about all this).

It turns out that only if we set the homeRealm strategy option explicitly to a empty string (homeRealm: ‘’) the whr parameter will not be sent to the provider.

I’m not sure whether this behavior of the homeRealm option is intended. If it is, it is not documented and is error-prone. If this behavior is not intended, it is a bug.

If this is a bug, I can send a PR to fix it.

What do you think?
TIA