Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this production ready? #113

Open
pzavolinsky opened this issue Dec 4, 2018 · 2 comments
Open

Is this production ready? #113

pzavolinsky opened this issue Dec 4, 2018 · 2 comments

Comments

@pzavolinsky
Copy link

I see you are using forked versions for some dependencies.

Currently that fails npm install in our containers (No git binary found in $PATH). We have no plans of adding git to our containers.

Do you have a stable, secure version of this package that does not rely on private forks of other NPM packages?
@pzavolinsky
Copy link
Author

pzavolinsky commented Dec 4, 2018 •
edited
Loading

xmldom looks like could be easily removed. You currently have v0.1.19-auth0_1 pinned down but 0.1.19-auth0.2 is pretty much the same as the public package: jindw/xmldom@master...auth0:master

xml-crypto I'm not so sure: node-saml/xml-crypto@master...auth0:65fa1e22c5884e45135d0bacccb99ad11e900bf1

@illiasaveliev
Copy link

Hi, I have the same issue. Do you have a version without git dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pzavolinsky @illiasaveliev