Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors do not end up in the express middleware chain #88

Open
zxlin opened this issue Dec 19, 2019 · 0 comments
Open

Errors do not end up in the express middleware chain #88

zxlin opened this issue Dec 19, 2019 · 0 comments
Labels
enhancement

Comments

@zxlin
Copy link

zxlin commented Dec 19, 2019

Description

Errors that take place in the middleware does not get put into the express middleware chain. Currently the middleware will simply call res.send to send the notice to the end user.

Reproduction

Just example code without req.user property will cause plaintext "Unauthorized" to be sent to the browser.

Environment

  • Version of this library used: 3.4.1
zxlin added a commit to zxlin/node-samlp that referenced this issue Dec 19, 2019
@zxlin
Fix auth0#88 - Pass errors to next in express
e85ffb3
@zxlin zxlin mentioned this issue Dec 19, 2019
Open
4 tasks
zxlin added a commit to zxlin/node-samlp that referenced this issue Dec 19, 2019
@zxlin
Fix auth0#88 - Pass errors to next in express
5554db7
@luuuis luuuis mentioned this issue Oct 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luuuis @zxlin