Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing endpoints for feature Organizations for Client Credentials changes #1046

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Oct 21, 2024

Changes

added 2 missing endpoints for the feature organization support for client credentials and respective tests:

DELETE /api/v2/organizations/{id}/client-grants/{grant_id}
POST /api/v2/organizations/{id}/client-grants

This PR also contains auth related changes for GA release of feature Organizations for Client Credentials as quoted:

The Auth SDKs may validate that the Organization sent in the request and the Organization returned in the tokens as claims match. These validation must be removed in case they exist, as the tokens may contain an org_id or org_name claim that are not present in the request.

Respective failing tests after removal of these checks have been removed.

References

Please look at #1033
API docs are not public yet.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner October 21, 2024 12:05
duedares-rvj
duedares-rvj previously approved these changes Oct 21, 2024
Copy link

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check getOrganizationClientGrants pagination params also from api.json

@kushalshit27
Copy link

Please add SDK usage examples

Copy link
Contributor Author

@tusharpandey13 tusharpandey13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushalshit27 kushalshit27 self-requested a review November 5, 2024 09:26
@tusharpandey13 tusharpandey13 merged commit 8c440b2 into master Nov 5, 2024
4 checks passed
@tusharpandey13 tusharpandey13 deleted the org-cc-missing-endpoints branch November 5, 2024 10:21
@tusharpandey13 tusharpandey13 mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants