Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SDK-4543): Support Organizations with Client Grants #736

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

evansims
Copy link
Member

Changes

This pull request adds functionality associated with Organizations and Client Grants. It introduces support for:

  • Retrieving Organizations associated with a Client Grant.
  • Retrieving Client Grants associated with an Organization.
  • Associating or disassociating client grants from organizations.

References

Please review internal ticket SDK-4543.

Testing

Tests have been added and updated to cover these changes. Coverage remains at 100%.

Contributor Checklist

@evansims evansims added Scope: Improvement Code changes including new features or enhancements to the library. Roadmap: Next Minor Targets the next minor release of the library. labels Nov 13, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6764f47) 100.00% compared to head (b294a1b) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #736   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1330      1338    +8     
===========================================
  Files             62        62           
  Lines           4615      4670   +55     
===========================================
+ Hits            4615      4670   +55     
Flag Coverage Δ
unittestsvalidate 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/API/Management/ClientGrants.php 100.00% <100.00%> (ø)
src/API/Management/Organizations.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review November 13, 2023 03:47
@evansims evansims requested a review from a team as a code owner November 13, 2023 03:47
@evansims evansims added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 9a01566 Nov 13, 2023
31 checks passed
@evansims evansims deleted the feat/org-client-credentials branch November 13, 2023 09:52
@evansims evansims mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: Next Minor Targets the next minor release of the library. Scope: Improvement Code changes including new features or enhancements to the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants