Guarantee return value is prime

aurora-opensource · Nov 19, 2024 · 7b4de73 · 7b4de73
1 parent 46e3c54
commit 7b4de73
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/au/code/au/utility/factoring.hh b/au/code/au/utility/factoring.hh
@@ -65,7 +65,7 @@ constexpr std::uintmax_t find_pollard_rho_factor(std::uintmax_t n) {
             ++cycle_length;
             factor = gcd(n, absolute_diff(tortoise, hare));
         }
-        if (factor > 1u && factor < n) {
+        if (factor < n) {
             return factor;
         }
     }
@@ -112,7 +112,11 @@ constexpr std::uintmax_t find_prime_factor(std::uintmax_t n) {
         return n;
     }
 
-    return find_pollard_rho_factor(n);
+    auto factor = find_pollard_rho_factor(n);
+    while (!is_prime(factor)) {
+        factor = find_pollard_rho_factor(factor);
+    }
+    return factor;
 }
 
 // Find the largest power of `factor` which divides `n`.