Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_routes method is a blocking I/O operation, missing async aget_routes method #396

Open
Vits-99 opened this issue Aug 23, 2024 · 0 comments
Open

get_routes method is a blocking I/O operation, missing async aget_routes method #396

Vits-99 opened this issue Aug 23, 2024 · 0 comments
Assignees
@Vits-99
Labels
enhancement Enhancement to existing features

Comments

@Vits-99
Copy link
Collaborator

Vits-99 commented Aug 23, 2024

get_routes() method we currently have is not async, so this should imply that the remote routes retrieval from Pinecone is blocking the event loop which is something we should prevent.

A "aget_routes" async method should be implemented.
@Vits-99 Vits-99 added the enhancement Enhancement to existing features label Aug 23, 2024
@Vits-99 Vits-99 self-assigned this Aug 23, 2024
@Vits-99 Vits-99 mentioned this issue Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vits-99 Vits-99

Labels
enhancement Enhancement to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vits-99