Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function calling #27

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Function calling #27

merged 6 commits into from
Dec 15, 2023

Conversation

simjak
Copy link
Member

@simjak simjak commented Dec 14, 2023

No description provided.

@simjak simjak self-assigned this Dec 14, 2023
@simjak simjak linked an issue Dec 14, 2023 that may be closed by this pull request
@simjak simjak marked this pull request as draft December 14, 2023 10:13
Copy link

PR Analysis

  • 🎯 Main theme: Function calling and routing
  • 📝 PR summary: This PR introduces a new Jupyter notebook that demonstrates how to generate a configuration for a function call and how to get a route layer. It also modifies the pyproject.toml file to ignore all linting errors in .ipynb files.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, because the PR is not large and the changes are straightforward.
  • 🔒 Security concerns: No

PR Feedback

  • 💡 General suggestions: The PR is generally well-structured and the code is clean. However, it would be beneficial to add some tests to ensure the new functionality works as expected.

  • 🤖 Code feedback:
    relevant filedocs/examples/function_calling.ipynb
    suggestion      It would be better to handle exceptions in a more specific way rather than using a generic Exception. This could help in debugging and understanding the specific issues that might arise. [important]
    relevant line"+ except Exception as e:\n",

    relevant filedocs/examples/function_calling.ipynb
    suggestion      It's a good practice to avoid hardcoding values like the model name 'gpt-4'. Consider making it a parameter or a constant that can be easily changed. [medium]
    relevant line"+ model=\"gpt-4\",\n",

    relevant filepyproject.toml
    suggestion      Ignoring all linting errors in `.ipynb` files might lead to overlooking potential issues in the code. Consider specifying the exact linting errors to ignore. [medium]
    relevant line"+\"*.ipynb\" = [\"ALL\"]"

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a0001d) 100.00% compared to head (74cd600) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          344       344           
=========================================
  Hits           344       344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simjak simjak merged commit 74cd600 into main Dec 15, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto generation of Decision utterances
1 participant