From 5a9597168cb8b54e470b311c1dc87b22582c3581 Mon Sep 17 00:00:00 2001
From: "bigopon.777@gmail.com" <bigopon.777@gmail.com>
Date: Fri, 24 May 2019 01:49:40 +1000
Subject: [PATCH 1/7] chore(tests): add failing test for 378

---
 test/repeat.issue-378.spec.ts | 39 +++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 test/repeat.issue-378.spec.ts

diff --git a/test/repeat.issue-378.spec.ts b/test/repeat.issue-378.spec.ts
new file mode 100644
index 0000000..b332109
--- /dev/null
+++ b/test/repeat.issue-378.spec.ts
@@ -0,0 +1,39 @@
+import './setup';
+import { StageComponent } from 'aurelia-testing';
+import { bootstrap } from 'aurelia-bootstrapper';
+
+// https://github.com/aurelia/templating-resources/issues/378
+fdescribe('repeat.issue-378.spec.ts', () => {
+  it('with matcher', async () => {
+    const component = StageComponent
+      .withResources()
+      .inView(`<label repeat.for="product of products">
+          <input
+            type="radio"
+            name="group2"
+            model.bind="product"
+            matcherss.bind="productMatcher"
+            checked.bind="selectedProduct" />
+          \${product.id} - \${product.name}
+        </label>`)
+      .boundTo(new class {
+        products = [
+          { id: 0, name: 'Motherboard' },
+          { id: 1, name: 'CPU' },
+          { id: 2, name: 'Memory' }
+        ];
+
+        productMatcher = (a, b) => {
+          console.log('matcher');
+          return a.id === b.id;
+        }
+
+        selectedProduct = { id: 1, name: 'CPU' };
+      });
+
+    await component.create(bootstrap);
+    const radios = document.querySelectorAll('input[type=radio]') as ArrayLike<HTMLInputElement>;
+    expect(radios.length).toBe(3);
+    expect(radios[1].checked).toBe(true);
+  });
+});

From a5796443016d2c87269dd05801c057fb45e5dc44 Mon Sep 17 00:00:00 2001
From: "bigopon.777@gmail.com" <bigopon.777@gmail.com>
Date: Fri, 24 May 2019 02:25:50 +1000
Subject: [PATCH 2/7] fix(repeat): properly find matcher binding

---
 src/aurelia-templating-resources.ts |  1 +
 src/interfaces.ts                   | 17 +++++++++++
 src/repeat.ts                       | 42 +++++++++++++++++++++++----
 test/repeat.issue-378.spec.ts       | 44 ++++++++++++++++++-----------
 test/test-utilities.ts              |  7 +++++
 5 files changed, 88 insertions(+), 23 deletions(-)
 create mode 100644 src/interfaces.ts
 create mode 100644 test/test-utilities.ts

diff --git a/src/aurelia-templating-resources.ts b/src/aurelia-templating-resources.ts
index ac11261..4527d19 100644
--- a/src/aurelia-templating-resources.ts
+++ b/src/aurelia-templating-resources.ts
@@ -37,6 +37,7 @@ import {
 } from './repeat-utilities';
 import {viewsRequireLifecycle} from './analyze-view-factory';
 import {injectAureliaHideStyleAtHead} from './aurelia-hide-style';
+import './interfaces';
 
 function configure(config: any) {
   injectAureliaHideStyleAtHead();
diff --git a/src/interfaces.ts b/src/interfaces.ts
new file mode 100644
index 0000000..23377ab
--- /dev/null
+++ b/src/interfaces.ts
@@ -0,0 +1,17 @@
+import { BindingExpression } from 'aurelia-binding';
+import { TargetInstruction } from 'aurelia-templating';
+
+/**@internal */
+declare module 'aurelia-templating' {
+  interface ViewFactory {
+    instructions: Record<string, TargetInstruction>;
+    template: DocumentFragment;
+  }
+}
+
+/**@internal */
+declare module 'aurelia-binding' {
+  interface BindingExpression {
+    targetProperty: string;
+  }
+}
diff --git a/src/repeat.ts b/src/repeat.ts
index bae8992..97c5423 100644
--- a/src/repeat.ts
+++ b/src/repeat.ts
@@ -1,6 +1,6 @@
 /*eslint no-loop-func:0, no-unused-vars:0*/
 import {inject} from 'aurelia-dependency-injection';
-import {ObserverLocator} from 'aurelia-binding';
+import {ObserverLocator, BindingExpression} from 'aurelia-binding';
 import {
   BoundViewFactory,
   TargetInstruction,
@@ -9,7 +9,8 @@ import {
   customAttribute,
   bindable,
   templateController,
-  View
+  View,
+  ViewFactory
 } from 'aurelia-templating';
 import {RepeatStrategyLocator} from './repeat-strategy-locator';
 import {
@@ -259,14 +260,38 @@ export class Repeat extends AbstractRepeater {
   }
 
   /**
+   * Capture and remove matcher binding is a way to cache matcher binding + reduce redundant work
+   * caused by multiple unnecessary matcher bindings
    * @internal
    */
   _captureAndRemoveMatcherBinding() {
-    if (this.viewFactory.viewFactory) {
-      const instructions = this.viewFactory.viewFactory.instructions;
+    const viewFactory: ViewFactory = this.viewFactory.viewFactory;
+    if (viewFactory) {
+      const template = viewFactory.template;
+      const instructions = viewFactory.instructions;
       const instructionIds = Object.keys(instructions);
+      // if the template has more than 1 immediate child element
+      // it's a repeat put on a <template/> element
+      // not valid for matcher binding
+      if (template.children.length > 1) {
+        return undefined;
+      }
+      // if the root element does not have any instruction
+      // it means there's no matcher binding
+      // no need to do any further work
+      const repeatedElement = template.firstElementChild;
+      if (!repeatedElement.hasAttribute('au-target-id')) {
+        return undefined;
+      }
+      const repeatedElementTargetId = repeatedElement.getAttribute('au-target-id');
       for (let i = 0; i < instructionIds.length; i++) {
-        const expressions = instructions[instructionIds[i]].expressions;
+        const instructionId = instructionIds[i];
+        // matcher binding can only works when root element is not a <template/>
+        // checking first el child
+        if (instructionId !== repeatedElementTargetId) {
+          continue;
+        }
+        const expressions = instructions[instructionId].expressions as BindingExpression[];
         if (expressions) {
           for (let ii = 0; ii < expressions.length; ii++) {
             if (expressions[ii].targetProperty === 'matcher') {
@@ -286,7 +311,12 @@ export class Repeat extends AbstractRepeater {
   viewCount() { return this.viewSlot.children.length; }
   views() { return this.viewSlot.children; }
   view(index) { return this.viewSlot.children[index]; }
-  matcher() { return this.matcherBinding ? this.matcherBinding.sourceExpression.evaluate(this.scope, this.matcherBinding.lookupFunctions) : null; }
+  matcher() {
+    const matcherBinding = this.matcherBinding;
+    return matcherBinding
+      ? matcherBinding.sourceExpression.evaluate(this.scope, matcherBinding.lookupFunctions)
+      : null;
+  }
 
   addView(bindingContext, overrideContext) {
     let view = this.viewFactory.create();
diff --git a/test/repeat.issue-378.spec.ts b/test/repeat.issue-378.spec.ts
index b332109..6602851 100644
--- a/test/repeat.issue-378.spec.ts
+++ b/test/repeat.issue-378.spec.ts
@@ -1,39 +1,49 @@
 import './setup';
 import { StageComponent } from 'aurelia-testing';
 import { bootstrap } from 'aurelia-bootstrapper';
+import { waitForFrames } from './test-utilities';
 
 // https://github.com/aurelia/templating-resources/issues/378
 fdescribe('repeat.issue-378.spec.ts', () => {
-  it('with matcher', async () => {
+  it('works with matcher, on a real element, + array', async () => {
+    const model = new class {
+      products = [
+        { id: 0, name: 'Motherboard' },
+        { id: 1, name: 'CPU' },
+        { id: 2, name: 'Memory' }
+      ];
+
+      productMatcher = (a, b) => {
+        return a.id === b.id;
+      }
+
+      selectedProduct = { id: 1, name: 'CPU' };
+    };
     const component = StageComponent
       .withResources()
-      .inView(`<label repeat.for="product of products">
+      .inView(`<label repeat.for="product of products" a.bind="product">
           <input
             type="radio"
             name="group2"
             model.bind="product"
-            matcherss.bind="productMatcher"
+            matcher.bind="productMatcher"
             checked.bind="selectedProduct" />
           \${product.id} - \${product.name}
         </label>`)
-      .boundTo(new class {
-        products = [
-          { id: 0, name: 'Motherboard' },
-          { id: 1, name: 'CPU' },
-          { id: 2, name: 'Memory' }
-        ];
-
-        productMatcher = (a, b) => {
-          console.log('matcher');
-          return a.id === b.id;
-        }
-
-        selectedProduct = { id: 1, name: 'CPU' };
-      });
+      .boundTo(model);
 
     await component.create(bootstrap);
     const radios = document.querySelectorAll('input[type=radio]') as ArrayLike<HTMLInputElement>;
     expect(radios.length).toBe(3);
     expect(radios[1].checked).toBe(true);
+
+    radios[2].click();
+    await waitForFrames(1);
+
+    expect(radios[1].checked).toBe(false);
+    expect(radios[2].checked).toBe(true);
+    expect(model.selectedProduct).toBe(model.products[2]);
+
+    component.dispose();
   });
 });
diff --git a/test/test-utilities.ts b/test/test-utilities.ts
new file mode 100644
index 0000000..30485dd
--- /dev/null
+++ b/test/test-utilities.ts
@@ -0,0 +1,7 @@
+
+
+export const waitForFrames = async (frameCount: number) => {
+  while (frameCount-- > 0) {
+    await new Promise(r => requestAnimationFrame(r));
+  }
+};

From 551598c3f840d6b8c31dca6c4db59c73f3ee1136 Mon Sep 17 00:00:00 2001
From: "bigopon.777@gmail.com" <bigopon.777@gmail.com>
Date: Fri, 24 May 2019 03:08:24 +1000
Subject: [PATCH 3/7] chore(tests): add more tests

---
 test/repeat.issue-378.spec.ts | 118 +++++++++++++++++++++++++++++++++-
 1 file changed, 116 insertions(+), 2 deletions(-)

diff --git a/test/repeat.issue-378.spec.ts b/test/repeat.issue-378.spec.ts
index 6602851..0210c77 100644
--- a/test/repeat.issue-378.spec.ts
+++ b/test/repeat.issue-378.spec.ts
@@ -5,7 +5,7 @@ import { waitForFrames } from './test-utilities';
 
 // https://github.com/aurelia/templating-resources/issues/378
 fdescribe('repeat.issue-378.spec.ts', () => {
-  it('works with matcher, on a real element, + array', async () => {
+  it('works with <div repeat[Array] /> -->> <... matcher />', async () => {
     const model = new class {
       products = [
         { id: 0, name: 'Motherboard' },
@@ -21,7 +21,7 @@ fdescribe('repeat.issue-378.spec.ts', () => {
     };
     const component = StageComponent
       .withResources()
-      .inView(`<label repeat.for="product of products" a.bind="product">
+      .inView(`<label repeat.for="product of products">
           <input
             type="radio"
             name="group2"
@@ -46,4 +46,118 @@ fdescribe('repeat.issue-378.spec.ts', () => {
 
     component.dispose();
   });
+
+  it('works with <div repeat[Map] /> -->> <... matcher />', async () => {
+    const model = new class {
+      products = new Map([
+        [0, 'Motherboard'],
+        [1, 'CPU'],
+        [2, 'Memory']
+      ]);
+
+      productMatcher = (a: [number, string], b: [number, string]) => {
+        return a[0] === b[0];
+      }
+
+      selectedProduct = [1, 'CPU'];
+    };
+    const component = StageComponent
+      .withResources()
+      .inView(`<label repeat.for="[id, name] of products">
+          <input
+            type="radio"
+            name="group2"
+            model.bind="[id, name]"
+            matcher.bind="productMatcher"
+            checked.bind="selectedProduct" />
+          \${id} - \${name}
+        </label>`)
+      .boundTo(model);
+
+    await component.create(bootstrap);
+    const radios = document.querySelectorAll('input[type=radio]') as ArrayLike<HTMLInputElement>;
+    expect(radios.length).toBe(3);
+    expect(radios[1].checked).toBe(true);
+
+    radios[2].click();
+    await waitForFrames(1);
+
+    expect(radios[1].checked).toBe(false);
+    expect(radios[2].checked).toBe(true);
+    expect(model.selectedProduct).toEqual(Array.from(model.products)[2]);
+
+    component.dispose();
+  });
+
+  describe('QA', () => {
+    it('works with matcher', async () => {
+      const model = new class App {
+        components: any[];
+        componentsAlternative: any;
+        objComponents: any[];
+        objComponentsAlternative: any[];
+        amatcher: (a: any, b: any) => boolean;
+        matcherCalls: number;
+
+        constructor() {
+          this.components = [];
+          for (let i = 1; i <= 10; i++) {
+            this.components.push(i);
+          }
+          this.componentsAlternative = this.components.slice(0).reverse();
+
+          this.objComponents = [];
+          this.objComponentsAlternative = [];
+          for (let i = 1; i <= 10; i++) {
+            this.objComponents.push({ id: i, text: i, cls: 'obj-comp' });
+            this.objComponentsAlternative.push({ id: i, text: i - 1, cls: 'obj-comp-alt' });
+          }
+
+          this.matcherCalls = 0;
+          this.amatcher = (a, b) => {
+            this.matcherCalls++;
+            return a.id === b.id;
+          };
+        }
+
+        swapArrays() {
+          [this.components, this.componentsAlternative] = [this.componentsAlternative, this.components];
+          [this.objComponents, this.objComponentsAlternative] = [this.objComponentsAlternative, this.objComponents];
+        }
+
+        reverse() {
+          this.components = this.components.slice(0).reverse();
+          this.objComponents = this.objComponents.slice(0).reverse();
+        }
+      };
+      const view = `
+        <button click.delegate="swapArrays()">Swap arrays</button>
+        <br>
+        <template
+          repeat.for="obj of objComponents"
+          matcher.bind="amatcher"
+          class="a-matcher \${obj.cls}">
+          [\${$index}]
+        </template>`;
+
+      const component = StageComponent
+        .withResources()
+        .inView(view)
+        .boundTo(model);
+
+      await component.create(bootstrap);
+
+      const viewModel = component.viewModel;
+      expect(viewModel.matcher()).toBe(model.amatcher);
+      expect(document.querySelectorAll('.obj-comp').length).toBe(10);
+
+      model.swapArrays();
+      await waitForFrames(2);
+
+      expect(document.querySelectorAll('.obj-comp-alt').length).toBe(10);
+      expect(model.matcherCalls).toBeGreaterThan(40);
+
+      component.dispose();
+    });
+  });
 });

From 62958e54e2b1db05a39e2358c7508294bc0f437e Mon Sep 17 00:00:00 2001
From: "bigopon.777@gmail.com" <bigopon.777@gmail.com>
Date: Fri, 24 May 2019 11:56:36 +1000
Subject: [PATCH 4/7] fix(repeat): ensure backward compat, fix tests

---
 src/repeat.ts                 | 51 ++++++++++++++++++++++-------------
 test/repeat.issue-378.spec.ts | 45 ++++++++++++++++++++++---------
 2 files changed, 65 insertions(+), 31 deletions(-)

diff --git a/src/repeat.ts b/src/repeat.ts
index 97c5423..6ca555b 100644
--- a/src/repeat.ts
+++ b/src/repeat.ts
@@ -29,6 +29,9 @@ import {AbstractRepeater} from './abstract-repeater';
 @templateController
 @inject(BoundViewFactory, TargetInstruction, ViewSlot, ViewResources, ObserverLocator, RepeatStrategyLocator)
 export class Repeat extends AbstractRepeater {
+
+  static useInnerMatcher = true;
+
   /**
    * List of items to bind the repeater to.
    *
@@ -269,7 +272,9 @@ export class Repeat extends AbstractRepeater {
     if (viewFactory) {
       const template = viewFactory.template;
       const instructions = viewFactory.instructions;
-      const instructionIds = Object.keys(instructions);
+      if (Repeat.useInnerMatcher) {
+        return extractMatcherBindingExpression(instructions);
+      }
       // if the template has more than 1 immediate child element
       // it's a repeat put on a <template/> element
       // not valid for matcher binding
@@ -284,24 +289,7 @@ export class Repeat extends AbstractRepeater {
         return undefined;
       }
       const repeatedElementTargetId = repeatedElement.getAttribute('au-target-id');
-      for (let i = 0; i < instructionIds.length; i++) {
-        const instructionId = instructionIds[i];
-        // matcher binding can only works when root element is not a <template/>
-        // checking first el child
-        if (instructionId !== repeatedElementTargetId) {
-          continue;
-        }
-        const expressions = instructions[instructionId].expressions as BindingExpression[];
-        if (expressions) {
-          for (let ii = 0; ii < expressions.length; ii++) {
-            if (expressions[ii].targetProperty === 'matcher') {
-              const matcherBinding = expressions[ii];
-              expressions.splice(ii, 1);
-              return matcherBinding;
-            }
-          }
-        }
-      }
+      return extractMatcherBindingExpression(instructions, repeatedElementTargetId);
     }
 
     return undefined;
@@ -362,3 +350,28 @@ export class Repeat extends AbstractRepeater {
     }
   }
 }
+
+/**
+ * Iterate a record of TargetInstruction and their expressions to find first binding expression that targets property named "matcher"
+ */
+const extractMatcherBindingExpression = (instructions: Record<string, TargetInstruction>, targetedElementId?: string): BindingExpression | undefined => {
+  const instructionIds = Object.keys(instructions);
+  for (let i = 0; i < instructionIds.length; i++) {
+    const instructionId = instructionIds[i];
+    // matcher binding can only works when root element is not a <template/>
+    // checking first el child
+    if (targetedElementId !== undefined && instructionId !== targetedElementId) {
+      continue;
+    }
+    const expressions = instructions[instructionId].expressions as BindingExpression[];
+    if (expressions) {
+      for (let ii = 0; ii < expressions.length; ii++) {
+        if (expressions[ii].targetProperty === 'matcher') {
+          const matcherBindingExpression = expressions[ii];
+          expressions.splice(ii, 1);
+          return matcherBindingExpression;
+        }
+      }
+    }
+  }
+};
diff --git a/test/repeat.issue-378.spec.ts b/test/repeat.issue-378.spec.ts
index 0210c77..2d0a91e 100644
--- a/test/repeat.issue-378.spec.ts
+++ b/test/repeat.issue-378.spec.ts
@@ -2,10 +2,12 @@ import './setup';
 import { StageComponent } from 'aurelia-testing';
 import { bootstrap } from 'aurelia-bootstrapper';
 import { waitForFrames } from './test-utilities';
+import { Repeat } from '../src/repeat';
 
 // https://github.com/aurelia/templating-resources/issues/378
 fdescribe('repeat.issue-378.spec.ts', () => {
   it('works with <div repeat[Array] /> -->> <... matcher />', async () => {
+    Repeat.useInnerMatcher = false;
     const model = new class {
       products = [
         { id: 0, name: 'Motherboard' },
@@ -45,9 +47,11 @@ fdescribe('repeat.issue-378.spec.ts', () => {
     expect(model.selectedProduct).toBe(model.products[2]);
 
     component.dispose();
+    Repeat.useInnerMatcher = true;
   });
 
   it('works with <div repeat[Map] /> -->> <... matcher />', async () => {
+    Repeat.useInnerMatcher = false;
     const model = new class {
       products = new Map([
         [0, 'Motherboard'],
@@ -87,17 +91,19 @@ fdescribe('repeat.issue-378.spec.ts', () => {
     expect(model.selectedProduct).toEqual(Array.from(model.products)[2]);
 
     component.dispose();
+    Repeat.useInnerMatcher = true;
   });
 
   describe('QA', () => {
     it('works with matcher', async () => {
       const model = new class App {
+
         components: any[];
         componentsAlternative: any;
         objComponents: any[];
         objComponentsAlternative: any[];
         amatcher: (a: any, b: any) => boolean;
-        matcherCalls: number;
+        matcherCallCount: number;
 
         constructor() {
           this.components = [];
@@ -113,9 +119,9 @@ fdescribe('repeat.issue-378.spec.ts', () => {
             this.objComponentsAlternative.push({ id: i, text: i - 1, cls: 'obj-comp-alt' });
           }
 
-          this.matcherCalls = 0;
+          this.matcherCallCount = 0;
           this.amatcher = (a, b) => {
-            this.matcherCalls++;
+            this.matcherCallCount++;
             return a.id === b.id;
           };
         }
@@ -130,18 +136,33 @@ fdescribe('repeat.issue-378.spec.ts', () => {
           this.objComponents = this.objComponents.slice(0).reverse();
         }
       };
-      const view = `
-        <button click.delegate="swapArrays()">Swap arrays</button>
+      const view =
+        `<button click.delegate="swapArrays()">Swap arrays</button>
         <br>
-        <template
+        <dummy
           repeat.for="obj of objComponents"
           matcher.bind="amatcher"
-          class="a-matcher \${obj.cls}">
-          [\${$index}]
-        </template>`;
+          class="a-matcher"
+          obj.bind="obj"
+          index.bind="$index">
+        </dummy>`;
 
       const component = StageComponent
-        .withResources()
+        .withResources([
+          class Dummy {
+            static $view = `<template class="\${obj.cls}" dataa-counter="\${counter}">[\${index}]</template>`;
+            static $resource = {
+              name: 'dummy',
+              bindables: ['obj', 'index']
+            };
+
+            counter = 0;
+
+            attached() {
+              this.counter++;
+            }
+          }
+        ] as any)
         .inView(view)
         .boundTo(model);
 
@@ -152,10 +173,10 @@ fdescribe('repeat.issue-378.spec.ts', () => {
       expect(document.querySelectorAll('.obj-comp').length).toBe(10);
 
       model.swapArrays();
-      await waitForFrames(2);
+      await waitForFrames(1);
 
       expect(document.querySelectorAll('.obj-comp-alt').length).toBe(10);
-      expect(model.matcherCalls).toBeGreaterThan(40);
+      expect(model.matcherCallCount).toBeGreaterThan(40);
 
       component.dispose();
     });

From 60e06e86f99d04004dd14cc67004e037d196ed20 Mon Sep 17 00:00:00 2001
From: "bigopon.777@gmail.com" <bigopon.777@gmail.com>
Date: Fri, 24 May 2019 11:57:46 +1000
Subject: [PATCH 5/7] chore(tests): remove fdescribe

---
 test/repeat.issue-378.spec.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/repeat.issue-378.spec.ts b/test/repeat.issue-378.spec.ts
index 2d0a91e..a89dcd7 100644
--- a/test/repeat.issue-378.spec.ts
+++ b/test/repeat.issue-378.spec.ts
@@ -5,7 +5,7 @@ import { waitForFrames } from './test-utilities';
 import { Repeat } from '../src/repeat';
 
 // https://github.com/aurelia/templating-resources/issues/378
-fdescribe('repeat.issue-378.spec.ts', () => {
+describe('repeat.issue-378.spec.ts', () => {
   it('works with <div repeat[Array] /> -->> <... matcher />', async () => {
     Repeat.useInnerMatcher = false;
     const model = new class {

From 6ebd64260efde6cd59e36a60191b50c64d24fc14 Mon Sep 17 00:00:00 2001
From: "bigopon.777@gmail.com" <bigopon.777@gmail.com>
Date: Mon, 1 Jul 2019 22:08:59 +1000
Subject: [PATCH 6/7] chore(repeat-matcher): linting & comments

---
 src/array-repeat-strategy.ts        | 30 +++++++++---------
 test/map-repeat-strategy.spec.ts    | 47 +++++++++++++++++------------
 test/mocks.ts                       | 39 ++++++++++++------------
 test/number-repeat-strategy.spec.ts |  6 ++--
 test/repeat.spec.ts                 |  8 ++---
 test/sanitize-html.spec.ts          |  4 +--
 test/test-interfaces.ts             |  3 ++
 7 files changed, 75 insertions(+), 62 deletions(-)

diff --git a/src/array-repeat-strategy.ts b/src/array-repeat-strategy.ts
index f190ee6..b7df4b0 100644
--- a/src/array-repeat-strategy.ts
+++ b/src/array-repeat-strategy.ts
@@ -1,5 +1,6 @@
 import {createFullOverrideContext, updateOverrideContexts, updateOverrideContext, indexOf} from './repeat-utilities';
 import {mergeSplice} from 'aurelia-binding';
+import { Repeat } from './repeat';
 
 /**
  * A strategy for repeating a template over an array.
@@ -20,29 +21,30 @@ export class ArrayRepeatStrategy {
    * @param items The new array instance.
    */
   instanceChanged(repeat, items) {
+    const $repeat = repeat as Repeat;
     const itemsLength = items.length;
 
     // if the new instance does not contain any items,
     // just remove all views and don't do any further processing
     if (!items || itemsLength === 0) {
-      repeat.removeAllViews(true, !repeat.viewsRequireLifecycle);
+      $repeat.removeAllViews(true, !$repeat.viewsRequireLifecycle);
       return;
     }
 
-    const children = repeat.views();
+    const children = $repeat.views();
     const viewsLength = children.length;
 
     // likewise, if we previously didn't have any views,
     // simply make them and return
     if (viewsLength === 0) {
-      this._standardProcessInstanceChanged(repeat, items);
+      this._standardProcessInstanceChanged($repeat, items);
       return;
     }
 
-    if (repeat.viewsRequireLifecycle) {
+    if ($repeat.viewsRequireLifecycle) {
       const childrenSnapshot = children.slice(0);
-      const itemNameInBindingContext = repeat.local;
-      const matcher = repeat.matcher();
+      const itemNameInBindingContext = $repeat.local;
+      const matcher = $repeat.matcher();
 
       // the cache of the current state (it will be transformed along with the views to keep track of indicies)
       let itemsPreviouslyInViews = [];
@@ -65,7 +67,7 @@ export class ArrayRepeatStrategy {
       let removePromise;
 
       if (itemsPreviouslyInViews.length > 0) {
-        removePromise = repeat.removeViews(viewsToRemove, true, !repeat.viewsRequireLifecycle);
+        removePromise = $repeat.removeViews(viewsToRemove, true, !$repeat.viewsRequireLifecycle);
         updateViews = () => {
           // update views (create new and move existing)
           for (let index = 0; index < itemsLength; index++) {
@@ -74,8 +76,8 @@ export class ArrayRepeatStrategy {
             let view;
 
             if (indexOfView === -1) { // create views for new items
-              const overrideContext = createFullOverrideContext(repeat, items[index], index, itemsLength);
-              repeat.insertView(index, overrideContext.bindingContext, overrideContext);
+              const overrideContext = createFullOverrideContext($repeat, items[index], index, itemsLength);
+              $repeat.insertView(index, overrideContext.bindingContext, overrideContext);
               // reflect the change in our cache list so indicies are valid
               itemsPreviouslyInViews.splice(index, 0, undefined);
             } else if (indexOfView === index) { // leave unchanged items
@@ -83,7 +85,7 @@ export class ArrayRepeatStrategy {
               itemsPreviouslyInViews[indexOfView] = undefined;
             } else { // move the element to the right place
               view = children[indexOfView];
-              repeat.moveView(indexOfView, index);
+              $repeat.moveView(indexOfView, index);
               itemsPreviouslyInViews.splice(indexOfView, 1);
               itemsPreviouslyInViews.splice(index, 0, undefined);
             }
@@ -95,12 +97,12 @@ export class ArrayRepeatStrategy {
 
           // remove extraneous elements in case of duplicates,
           // also update binding contexts if objects changed using the matcher function
-          this._inPlaceProcessItems(repeat, items);
+          this._inPlaceProcessItems($repeat, items);
         };
       } else {
         // if all of the items are different, remove all and add all from scratch
-        removePromise = repeat.removeAllViews(true, !repeat.viewsRequireLifecycle);
-        updateViews = () => this._standardProcessInstanceChanged(repeat, items);
+        removePromise = $repeat.removeAllViews(true, !$repeat.viewsRequireLifecycle);
+        updateViews = () => this._standardProcessInstanceChanged($repeat, items);
       }
 
       if (removePromise instanceof Promise) {
@@ -110,7 +112,7 @@ export class ArrayRepeatStrategy {
       }
     } else {
       // no lifecycle needed, use the fast in-place processing
-      this._inPlaceProcessItems(repeat, items);
+      this._inPlaceProcessItems($repeat, items);
     }
   }
 
diff --git a/test/map-repeat-strategy.spec.ts b/test/map-repeat-strategy.spec.ts
index d595e36..3f6deb2 100644
--- a/test/map-repeat-strategy.spec.ts
+++ b/test/map-repeat-strategy.spec.ts
@@ -45,57 +45,64 @@ describe('MapRepeatStrategy', () => {
       view3.bindingContext = { item: ['john', 'doe'] };
       view3.overrideContext = {};
       viewSlot.children = [view1, view2, view3];
-      viewFactorySpy = spyOn(viewFactory, 'create').and.callFake(() => {});
+      viewFactorySpy = spyOn(viewFactory, 'create').and.callFake(() => {/**/});
     });
-  
+
     it('should correctly handle adding item (i.e Map.prototype.set())', () => {
-      repeat = new Repeat(new ViewFactoryMock(), instructionMock, viewSlot, viewResourcesMock, new ObserverLocator());
+      repeat = new Repeat(
+        new ViewFactoryMock(),
+        instructionMock,
+        viewSlot,
+        viewResourcesMock,
+        new ObserverLocator(),
+        null
+      );
       let bindingContext = {};
       repeat.scope = { bindingContext, overrideContext: createOverrideContext(bindingContext) };
       records = [
-        {"type": "add", "object": {}, "key": 'norf'}
-      ]
+        {'type': 'add', 'object': {}, 'key': 'norf'}
+      ];
       items = new Map([['foo', 'bar'], ['qux', 'qax'], ['john', 'doe'], ['norf', 'narf']]);
-      spyOn(viewSlot, 'removeAt').and.callFake(() => { return new ViewMock();});
+      spyOn(viewSlot, 'removeAt').and.callFake(() => { return new ViewMock(); });
       strategy.instanceMutated(repeat, items, records);
-    
+
       expect(viewSlot.children.length).toBe(4);
       expect(viewSlot.children[3].bindingContext.key).toBe('norf');
       expect(viewSlot.children[3].overrideContext.$index).toBe(3);
       expect(viewSlot.children[3].overrideContext.$first).toBe(false);
       expect(viewSlot.children[3].overrideContext.$last).toBe(true);
     });
-  
+
     it('should correctly handle clear items (i.e Map.prototype.clear())', () => {
       let view4 = new ViewMock();
       view4.bindingContext = { item: ['norf', 'narf'] };
       view4.overrideContext = {};
       let viewSlotMock = new ViewSlotMock();
       viewSlotMock.children = [view1, view2, view3, view4];
-      repeat = new Repeat(new ViewFactoryMock(), instructionMock, viewSlotMock, viewResourcesMock, new ObserverLocator());
+      repeat = new Repeat(new ViewFactoryMock(), instructionMock, viewSlotMock, viewResourcesMock, new ObserverLocator(), null);
       let bindingContext = {};
       repeat.scope = { bindingContext, overrideContext: createOverrideContext(bindingContext) };
       records = [
-        {"type": "clear", "object": {}}
-      ]
+        {'type': 'clear', 'object': {}}
+      ];
       items = new Map();
       strategy.instanceMutated(repeat, items, records);
-    
+
       expect(viewSlotMock.children.length).toBe(0);
     });
-  
+
     it('should correctly handle adding items after clear (issue 287)', () => {
       viewSlot.children = [view1, view2, view3];
-      repeat = new Repeat(new ViewFactoryMock(), instructionMock, viewSlot, viewResourcesMock, new ObserverLocator());
+      repeat = new Repeat(new ViewFactoryMock(), instructionMock, viewSlot, viewResourcesMock, new ObserverLocator(), null);
       let bindingContext = {};
       repeat.scope = { bindingContext, overrideContext: createOverrideContext(bindingContext) };
       records = [
-        {"type": "clear", "object": {}},
-        {"type": "add", "object": {}, "key": 'foo'},
-        {"type": "add", "object": {}, "key": 'qux'},
-        {"type": "add", "object": {}, "key": 'john'},
-        {"type": "add", "object": {}, "key": 'norf'}
-      ]
+        {'type': 'clear', 'object': {}},
+        {'type': 'add', 'object': {}, 'key': 'foo'},
+        {'type': 'add', 'object': {}, 'key': 'qux'},
+        {'type': 'add', 'object': {}, 'key': 'john'},
+        {'type': 'add', 'object': {}, 'key': 'norf'}
+      ];
       items = new Map([['foo', 'bar'], ['qux', 'qax'], ['john', 'doe'], ['norf', 'narf']]);
       strategy.instanceMutated(repeat, items, records);
 
diff --git a/test/mocks.ts b/test/mocks.ts
index 0abf50b..8e9b015 100644
--- a/test/mocks.ts
+++ b/test/mocks.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-empty
 import { Repeat } from '../src/repeat';
 
 export class ViewSlotMock {
@@ -5,21 +6,21 @@ export class ViewSlotMock {
   constructor() {
     this.children = [];
   }
-  removeAll(){
+  removeAll() {
     this.children.splice(0, this.children.length);
   }
-  add(view){
+  add(view) {
     this.children.push(view);
   }
-  insert(index, view){
-    if(index < 0) {
-      throw "negative index";
+  insert(index, view) {
+    if (index < 0) {
+      throw 'negative index';
     }
     this.children.splice(index, 0, view);
   }
-  removeAt(index){
-    if(index < 0) {
-      throw "negative index";
+  removeAt(index) {
+    if (index < 0) {
+      throw 'negative index';
     }
     this.children.splice(index, 1);
   }
@@ -32,30 +33,30 @@ export class ViewMock {
     this.bindingContext = bindingContext;
     this.overrideContext = overrideContext;
   }
-  attached(){}
-  detached(){}
-  unbind(){}
-  returnToCache(){}
+  attached() {}
+  detached() {}
+  unbind() {}
+  returnToCache() {}
 }
 
 export class BoundViewFactoryMock {
   _viewsRequireLifecycle = true;
-  create(){
-    return { bind(){} };
-  };
-  removeAll(){};
+  create() {
+    return { bind() {} };
+  }
+  removeAll() {}
 }
 
 export class ViewFactoryMock {
   _viewsRequireLifecycle = true;
-  create(){
+  create() {
     return new ViewMock();
   }
 }
 
 export class ArrayObserverMock {
-  subscribe(){};
-  unsubscribe(){};
+  subscribe() {}
+  unsubscribe() {}
 }
 
 export class RepeatStrategyMock {
diff --git a/test/number-repeat-strategy.spec.ts b/test/number-repeat-strategy.spec.ts
index 758a81c..2c7aa67 100644
--- a/test/number-repeat-strategy.spec.ts
+++ b/test/number-repeat-strategy.spec.ts
@@ -6,7 +6,7 @@ import {Container} from 'aurelia-dependency-injection';
 import {Repeat} from '../src/repeat';
 import {RepeatStrategyLocator} from '../src/repeat-strategy-locator';
 import {NumberRepeatStrategy} from '../src/number-repeat-strategy';
-import {ViewSlotMock, BoundViewFactoryMock, RepeatStrategyMock, ViewMock, ArrayObserverMock, ViewFactoryMock, instructionMock, viewResourcesMock} from './mocks';
+import {ViewSlotMock, BoundViewFactoryMock, RepeatStrategyMock, ViewFactoryMock, instructionMock, viewResourcesMock} from './mocks';
 import {bootstrap} from 'aurelia-bootstrapper';
 
 describe('NumberRepeatStrategy', () => {
@@ -27,7 +27,7 @@ describe('NumberRepeatStrategy', () => {
     container.registerInstance(ObserverLocator, observerLocator);
     container.registerInstance(RepeatStrategyLocator, repeatStrategyLocator);
 
-    component = StageComponent.withResources().inView('<div repeat.for="item of items"></div>').boundTo({ items: [] })
+    component = StageComponent.withResources().inView('<div repeat.for="item of items"></div>').boundTo({ items: [] });
 
     component.create(bootstrap).then(() => {
       repeat = component.viewModel;
@@ -41,7 +41,7 @@ describe('NumberRepeatStrategy', () => {
 
   describe('instanceChanged', () => {
     beforeEach(() => {
-      repeat = new Repeat(new ViewFactoryMock(), instructionMock, viewSlot, viewResourcesMock, new ObserverLocator());
+      repeat = new Repeat(new ViewFactoryMock(), instructionMock, viewSlot, viewResourcesMock, new ObserverLocator(), null);
       let bindingContext = {};
       repeat.scope = { bindingContext, overrideContext: createOverrideContext(bindingContext) };
       viewSlot.children = [];
diff --git a/test/repeat.spec.ts b/test/repeat.spec.ts
index a5bed13..e613146 100644
--- a/test/repeat.spec.ts
+++ b/test/repeat.spec.ts
@@ -43,7 +43,7 @@ describe('repeat', () => {
       view1 = new ViewMock();
       view2 = new ViewMock();
       viewSlot.children = [view1, view2];
-      spyOn(repeatStrategyLocator, 'getStrategy').and.callFake(() => { return repeatStrategyMock});
+      spyOn(repeatStrategyLocator, 'getStrategy').and.callFake(() => { return repeatStrategyMock; });
     });
 
     it('should do nothing if no items provided', () => {
@@ -69,7 +69,7 @@ describe('repeat', () => {
       spyOn(viewSlot, 'removeAll');
       repeat.unbind();
 
-      expect(viewSlot.removeAll).toHaveBeenCalled(); //With(true, true);
+      expect(viewSlot.removeAll).toHaveBeenCalled(); // With(true, true);
     });
 
     it('should unsubscribe collection', () => {
@@ -101,7 +101,7 @@ describe('repeat', () => {
 
   describe('itemsChanged', () => {
     beforeEach(() => {
-      spyOn(repeatStrategyLocator, 'getStrategy').and.callFake(() => { return repeatStrategyMock});
+      spyOn(repeatStrategyLocator, 'getStrategy').and.callFake(() => { return repeatStrategyMock; });
     });
 
     it('should unsubscribe collection', () => {
@@ -124,7 +124,7 @@ describe('repeat', () => {
     it('should subscribe to changes', () => {
       repeat.items = ['foo', 'bar'];
       let collectionObserver = new ArrayObserverMock();
-      spyOn(repeatStrategyMock, 'getCollectionObserver').and.callFake(() => { return collectionObserver });
+      spyOn(repeatStrategyMock, 'getCollectionObserver').and.callFake(() => { return collectionObserver; });
       spyOn(collectionObserver, 'subscribe');
       repeat.itemsChanged();
 
diff --git a/test/sanitize-html.spec.ts b/test/sanitize-html.spec.ts
index 6170cb9..084705f 100644
--- a/test/sanitize-html.spec.ts
+++ b/test/sanitize-html.spec.ts
@@ -3,14 +3,14 @@ import {SanitizeHTMLValueConverter} from '../src/sanitize-html';
 import {HTMLSanitizer} from '../src/html-sanitizer';
 
 describe('SanitizeHtmlValueConverter', () => {
-  var converter;
+  let converter;
 
   beforeEach(() => {
     converter = new SanitizeHTMLValueConverter(new HTMLSanitizer());
   });
 
   it('defaultSanitizer should remove script tags', () => {
-    var a = '<script src="http://www.evil.org"></script>',
+    let a = '<script src="http://www.evil.org"></script>',
         b = '<div><script src="http://www.evil.org"></script></div>',
         c = 'foo <script src="http://www.evil.org"></script> bar',
         d = '<div></div>',
diff --git a/test/test-interfaces.ts b/test/test-interfaces.ts
index be271db..228a703 100644
--- a/test/test-interfaces.ts
+++ b/test/test-interfaces.ts
@@ -1,5 +1,8 @@
 import 'aurelia-templating';
 
+/**
+ * @internal
+ */
 declare module 'aurelia-templating' {
   interface HtmlBehaviorResource {
     elementName: string | null;

From 83be4826bd6e252e025053ddfa90a9e0d065e75f Mon Sep 17 00:00:00 2001
From: "bigopon.777@gmail.com" <bigopon.777@gmail.com>
Date: Mon, 1 Jul 2019 22:31:23 +1000
Subject: [PATCH 7/7] chore(repeat): comments & tests

---
 src/repeat.ts                 |  8 +++++
 test/repeat.issue-378.spec.ts | 66 ++++++++++++++++++++++++++++++++++-
 2 files changed, 73 insertions(+), 1 deletion(-)

diff --git a/src/repeat.ts b/src/repeat.ts
index 6ca555b..b8bf089 100644
--- a/src/repeat.ts
+++ b/src/repeat.ts
@@ -30,6 +30,13 @@ import {AbstractRepeater} from './abstract-repeater';
 @inject(BoundViewFactory, TargetInstruction, ViewSlot, ViewResources, ObserverLocator, RepeatStrategyLocator)
 export class Repeat extends AbstractRepeater {
 
+  /**
+   * Setting this to `true` to enable legacy behavior, where a repeat would take first `matcher` binding
+   * any where inside its view if there's no `matcher` binding on the repeated element itself.
+   *
+   * Default value is true to avoid breaking change
+   * @default true
+   */
   static useInnerMatcher = true;
 
   /**
@@ -272,6 +279,7 @@ export class Repeat extends AbstractRepeater {
     if (viewFactory) {
       const template = viewFactory.template;
       const instructions = viewFactory.instructions;
+      // legacy behavior enabled when Repeat.useInnerMathcer === true
       if (Repeat.useInnerMatcher) {
         return extractMatcherBindingExpression(instructions);
       }
diff --git a/test/repeat.issue-378.spec.ts b/test/repeat.issue-378.spec.ts
index a89dcd7..df1d14b 100644
--- a/test/repeat.issue-378.spec.ts
+++ b/test/repeat.issue-378.spec.ts
@@ -1,11 +1,75 @@
 import './setup';
-import { StageComponent } from 'aurelia-testing';
+import * as AuBinding from 'aurelia-binding';
+import { StageComponent, ComponentTester } from 'aurelia-testing';
 import { bootstrap } from 'aurelia-bootstrapper';
 import { waitForFrames } from './test-utilities';
 import { Repeat } from '../src/repeat';
 
 // https://github.com/aurelia/templating-resources/issues/378
 describe('repeat.issue-378.spec.ts', () => {
+  it('extracts matcher binding corectly when matcher is on repeated element', async () => {
+    const model = new class {
+      products = [
+        { id: 0, name: 'Motherboard' },
+        { id: 1, name: 'CPU' },
+        { id: 2, name: 'Memory' }
+      ];
+
+      productMatcher = (a, b) => {
+        return a.id === b.id;
+      }
+
+      selectedProduct = { id: 1, name: 'CPU' };
+    };
+    const component: ComponentTester<Repeat> = StageComponent
+      .withResources()
+      .inView(`<label repeat.for="product of products" matcher.bind="productMatcher">
+          \${product.id} - \${product.name}
+        </label>`)
+      .boundTo(model);
+
+    await component.create(bootstrap);
+
+    const matcherBinding = component.viewModel.matcherBinding;
+    expect(matcherBinding).not.toBe(undefined, 'matcher binding should have existed');
+    expect(matcherBinding instanceof (AuBinding as any).BindingExpression).toBe(true, 'it should have been a binding expression');
+
+    // verify that it leaves attribute intact
+    // even when binding expression is extracted
+    // todo: should it remove it?
+    expect(
+      Array.from(component['host'].querySelectorAll('label'))
+        .filter((label: HTMLElement) => label.hasAttribute('matcher.bind')).length).toBe(3);
+  });
+
+  it('does not extracts matcher binding when matcher is on repeated <template/> element', async () => {
+    const model = new class {
+      products = [
+        { id: 0, name: 'Motherboard' },
+        { id: 1, name: 'CPU' },
+        { id: 2, name: 'Memory' }
+      ];
+
+      productMatcher = (a, b) => {
+        return a.id === b.id;
+      }
+
+      selectedProduct = { id: 1, name: 'CPU' };
+    };
+    const component: ComponentTester<Repeat> = StageComponent
+      .withResources()
+      .inView(`<template repeat.for="product of products" matcher.bind="productMatcher">
+          <span>\${product.id} - \${product.name}</span>
+        </template>`)
+      .boundTo(model);
+
+    await component.create(bootstrap);
+
+    const matcherBinding = component.viewModel.matcherBinding;
+    expect(matcherBinding).toBe(undefined, 'matcher binding should have existed');
+
+  });
+
   it('works with <div repeat[Array] /> -->> <... matcher />', async () => {
     Repeat.useInnerMatcher = false;
     const model = new class {