-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome store Redux DevTools v3 not working. Redux DevTools v2 via download still works though #124
Comments
uff good to know. I'll check the breaking changes, most likely removal/renames of extension methods |
Sry for coming back to you so late @doktordirk, in the middle of preparations for the release of Baby v2.0 ;). The change is really minimal as we've been using a deprecated style (devToolsExtension) to access the global Extension https://github.com/aurelia/store/blob/master/src/store.ts#L324 instead of (REDUX_DEVTOOLS_EXTENSION). The trouble though is that this will cause the DevToolsOptions to be updated and some parts got removed in an undocumented matter, like I'll need to grab another quite moment to go check through all the missing parts and also to decide what type of version bump this will result in. TbH I'm totally unsure whether this is a PATCH (just get the tools working again) or MAJOR (existing functionallity removed due to external dependency). Whats your opinion on that? |
if devTools 2.x still works, then PATCH, if not not, MAJOR imho (plus a deprecation note to previous version) |
Any progress or plans regarding this issue? We love Aurelia Store at my work but somewhat worried since we rely on the extension integration to be able to work efficiently. |
the issue with the deprecated check has been already published, I guess it should now work with v3 but alas the update of settings is still to be fixed I guess |
More an FYI. Redux DevTools v3 seem to have breaking changes. See also reduxjs/redux-devtools#1054
One can still get though a working version v2 following the
extension.zip
instructions here https://github.com/zalmoxisus/redux-devtools-extensionThe text was updated successfully, but these errors were encountered: