You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current behavior:
Presently, the animation abstraction offers up addClass() and removeClass(). This leads to code like this:
if (reveal) {
this.animator.addClass(...);
else {
this.animator.removeClass(...);
}
Not the end of the world, but a little verbose.
Expected/desired behavior:
I would suggest a toggleClass() method on the abstraction. It is certainly in keeping with many of the animation libraries out there, including jQuery's, and it would allow the above to be reduced to:
this.animator.toggleClass(...);
What is the motivation / use case for changing the behavior?
Terseness, clarity, and harmony with many animation libraries' conventional approach.
The text was updated successfully, but these errors were encountered:
I'm submitting a feature request
1.0.1
Please tell us about your environment:
Operating System:
OSX 10.x
Node Version:
7.3.0
3.10.10
JSPM 0.16.53
Browser:
all
Language:
ESNext
Current behavior:
Presently, the animation abstraction offers up
addClass()
andremoveClass()
. This leads to code like this:Not the end of the world, but a little verbose.
Expected/desired behavior:
I would suggest a
toggleClass()
method on the abstraction. It is certainly in keeping with many of the animation libraries out there, including jQuery's, and it would allow the above to be reduced to:Terseness, clarity, and harmony with many animation libraries' conventional approach.
The text was updated successfully, but these errors were encountered: