Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes for discussion moving forward #13

Open
harikt opened this issue Jan 28, 2022 · 6 comments
Open

Notes for discussion moving forward #13

harikt opened this issue Jan 28, 2022 · 6 comments
Assignees

Comments

@harikt
Copy link
Member

harikt commented Jan 28, 2022

Hi all ( who all are the maintainers of the repo)

Some notes copied from auraphp/Aura.Cli_Kernel#12 (comment) by @pmjones

  1. The Aura 3.x series was for PHP 5.6 and later.
  2. The Aura 4.x series is for PHP 7.2 and later.
  3. I imagine a 5.x series, if you want to start one, should be for 8.0 (or perhaps 8.1?) and later.

#Below are some of the Suggestions

Unittest and compatibility

If we want to support 3.x, we should probably use https://packagist.org/packages/yoast/phpunit-polyfills . This will help us to move forward very easily with PHPUnit tests.

Releases

Earlier releases were using the bin script provided in this repo. But iirc, things were not working in 8.x versions. So may want to use producer or according to what you guys follow. Producer is throwing errors in 8.1. So either we need to fix it.

Notify on google group on releases

When new releases are tagged, it may be better to notify the google group.

@harikt
Copy link
Member Author

harikt commented Jan 28, 2022

I have been thinking, if we can support 3.x version of aura upto 8.1 via the help of polyfill, we should drop 4.x series of aura. But start fresh with 8.1 as we can utilise the language level features which will be 5.x.

Supporting 4.x for 7.x series seems not right at this point. The 7.4 support for security releases will end on 28 Nov 2022.

@koriym
Copy link
Member

koriym commented Jan 29, 2022

I thought that the main reason we have a 4.x branch is that one version of phpunit cannot cover a wide range of PHP versions. (It's a pity that phpunit breaks backwards compatibility). If that can be solved with proper polyfill in 3.x (instead of homemade polyfill), I think @harikt has a good point.

@koriym
Copy link
Member

koriym commented Jan 29, 2022

It has been more than 10 years since the first release of Aura, but it has not lost its value of a solid, minimalistic code set with no dependencies.

What people are looking for in an Aura project today is its continuity rather than new features with new PHP versions. I think continuity without breaking backward compatibility is key.

@harikt
Copy link
Member Author

harikt commented Jan 29, 2022

Aura.Router can target 3.x than 4.x if we can use the polyfill.

Aura.Session have not released a 3.x , so probably we can skip 3.x and move 4.x .

This is what I think for the current two. There are other packages we can explore if you guys agree with it.

@koriym
Copy link
Member

koriym commented Jan 30, 2022

Aura.Session have not released a 3.x , so probably we can skip 3.x and move 4.x .

What about update 3.x and skip 4.x ?

@harikt
Copy link
Member Author

harikt commented Jan 30, 2022

@koriym that will also be helpful for people who use 2.x. So yes I am okay with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants