Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MushraAudioControl.convolve() don't handle 96kHz samplerate #97

Open
a7brusco opened this issue Aug 10, 2022 · 2 comments
Open

MushraAudioControl.convolve() don't handle 96kHz samplerate #97

a7brusco opened this issue Aug 10, 2022 · 2 comments

Comments

@a7brusco
Copy link

I was testing webmushra which works well with my configuration (I use pymushra to serve the website).
A colleague tested it and had some trouble getting the index page (with the default configuration).
After debugging, we discovered that his Audio Context was running at 96 kHz sample rate (mine was 48 kHz).
The error that crashes the website occurs when the MushraAudioControl calls the convolve method.
To solve this problem, we change the sample rate of the audio interface in the Windows settings to 48 kHz.

Here is the console log of his Chrome while running pymushra.
webmushra_error

@faroit
Copy link
Collaborator

faroit commented Aug 10, 2022

Uh. I didn't know that browser do support >48khz these days.

Not sure how to solve this. Any ideas yourself?

@a7brusco
Copy link
Author

I'm not very good with all the web stuff.
I've been practicing a bit with the WebAudio API (just enough to debug this problem).

I noticed that the convolve method of MushraAudioControl could not work because it does not get the _coefficient parameter.

Maybe adding the low-pass coefficients for 96kHz in the createLowerAnchor35 and createLowerAnchor70 method is enough to solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants