Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio playing from beginning after playback finished #135

Open
judithK10 opened this issue Nov 29, 2024 · 1 comment
Open

Audio playing from beginning after playback finished #135

judithK10 opened this issue Nov 29, 2024 · 1 comment

Comments

@judithK10
Copy link

judithK10 commented Nov 29, 2024

Hi,

I've observed an unexpected behavior when using the config file mushra_noloop_nowav.yaml. I would expect that the audio is played once (because enableLooping is set to false) and after the playback finished, the progress bar should be reset to position zero.

However, what I observed instead was that the audio was played once, but then it continued to play a few more audio samples from the beginning of the audio (as also shown by the progress bar). For audio files that don't have silence at the beginning, this results in strange sounds at the end of the playback.

Screenshot from the page after the audio was played (tried with Firefox and Google Chrome):
grafik

I noticed that the progressbar is correctly reset to zero when I add a break after this line: https://github.com/audiolabs/webMUSHRA/blob/master/lib/webmushra/audio/MushraAudioControl.js#L286

Was this issue observed before, or is there anything that could be wrong with my setup? And could the additional break be a reasonable solution?

@faroit
Copy link
Collaborator

faroit commented Dec 12, 2024

Hi @judithK10 I am unable to reproduce at this point but even worse I see that mushra_noloop_nowav loops all the time when running on Brave for me. So this is def a bug.

would you be able to provide a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants