Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching design doc on blk and its code #78

Open
erichchan999 opened this issue Mar 27, 2024 · 1 comment
Open

matching design doc on blk and its code #78

erichchan999 opened this issue Mar 27, 2024 · 1 comment

Comments

@erichchan999
Copy link
Contributor

Currently the design document for storage devices in Listing 5.1 does not match the code. These need to be changed:

  • removing count and address fields in blk_response. These were included to simplify the bookkeeping process, and as we implement the various blk components have found them unneccessary.
  • QUEUE_SIZE is defined separately for both queues -> BLK_REQ_QUEUE_SIZE, BLK_RESP_QUEUE_SIZE
  • The response enum is called a response_status, and is defined separately from the response struct

In Listing 5.2 outlining blk storage information fields:

  • an additional sector_size field is added to communicate the minimum blocksize, this may be smaller than the transfer size and will require a different implementation.
  • blocksize renamed to block_size for consistency
  • additional comments
@Ivan-Velickovic
Copy link
Collaborator

Also, the head and tail indices seem to be reversed compared to the network queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants