Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sDDF LWIP cleanup #9

Closed
2 of 4 tasks
Ivan-Velickovic opened this issue Feb 2, 2024 · 1 comment
Closed
2 of 4 tasks

sDDF LWIP cleanup #9

Ivan-Velickovic opened this issue Feb 2, 2024 · 1 comment

Comments

@Ivan-Velickovic
Copy link
Collaborator

Ivan-Velickovic commented Feb 2, 2024

As pointed out by @jearc, the LWIP code from the echo server is fairly tangled with the rest of the code-base which is becoming not ideal as we use LWIP outside the echo server context and inside the Kitty example.

The following is a list of things that should be cleaned up:

  • sddf/util/timer.h is LWIP specific
  • sddf/network/componenets/lwip_timer.c is LWIP specific too
  • Build an LWIP static library - have a Makefile that takes in the client-specific LWIP options to make it easier to build a network client, right now the process to compile LWIP is tedious.
  • Move lwip.c to echo_server.c and have sddf/network/components/lwip.c be generic LWIP code that does not depend on the client - e.g there should be no notified entry point for lwip.c.
@Ivan-Velickovic
Copy link
Collaborator Author

Made au-ts/sddf#57 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant