From 37fe8cc2e8bbacea52c68ca57eea7b71545922c0 Mon Sep 17 00:00:00 2001 From: Ivan-Velickovic Date: Wed, 6 Nov 2024 12:06:43 +1100 Subject: [PATCH] Remove unnecessary comments Signed-off-by: Ivan-Velickovic --- examples/simple/vmm.c | 7 ------- include/libvmm/virq.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/examples/simple/vmm.c b/examples/simple/vmm.c index ce260e2e8..133bbf9d4 100644 --- a/examples/simple/vmm.c +++ b/examples/simple/vmm.c @@ -13,13 +13,6 @@ #include #include -// @ivanv: ideally we would have none of these hardcoded values -// initrd, ram size come from the DTB -// We can probably add a node for the DTB addr and then use that. -// Part of the problem is that we might need multiple DTBs for the same example -// e.g one DTB for VMM one, one DTB for VMM two. we should be able to hide all -// of this in the build system to avoid doing any run-time DTB stuff. - /* * As this is just an example, for simplicity we just make the size of the * guest's "RAM" the same for all platforms. For just booting Linux with a diff --git a/include/libvmm/virq.h b/include/libvmm/virq.h index 0b9213642..a3a324f01 100644 --- a/include/libvmm/virq.h +++ b/include/libvmm/virq.h @@ -24,9 +24,6 @@ bool virq_inject(size_t vcpu_id, int irq); * passthrough access to a particular device on the hardware. * After registering the passthrough IRQ, call `virq_handle_passthrough` when * the IRQ has come through from seL4. - * - * @ivanv: currently this API assumes a Microkit environment. This should be changed - * if/when we make libvmm agnostic to the seL4 environment it is running in. */ bool virq_register_passthrough(size_t vcpu_id, size_t irq, microkit_channel irq_ch); bool virq_handle_passthrough(microkit_channel irq_ch);