Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support resId in the way that makes sense #63

Open
atsushieno opened this issue Mar 25, 2024 · 3 comments
Open

support resId in the way that makes sense #63

atsushieno opened this issue Mar 25, 2024 · 3 comments

Comments

@atsushieno
Copy link
Owner

Currently property values are stored without paying any attention to resId. But having one single value for a property seems fundamental mistake. When resId is involved, the property values are stored like a map. juce_midi_ci has the same problem. Common Rules for PE specification itself is indeed problematic by stating almost nothing about resId. There is no access to what kind of resId is available, especially to clients.

@atsushieno
Copy link
Owner Author

  • updating property value from client request should involve resId and requireResId
  • updating property value locally should involve resId and requireResId
  • subscription should be keyed with both resource and resId
  • retrieving property value without resId should be prevented when requireResId is true

@atsushieno
Copy link
Owner Author

55a4f9d started some resId related changes.

@atsushieno
Copy link
Owner Author

I'm rather thinking, current PropertyValue should become abstract and current one should become a specialized one like CommonRulesPropertyValue. It comes with a problem on serializability though.

We should probably "serialize" the configuration itself just as UMP bytes. But that's going to be another issue (that may be first to resolve though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant