feat(x/photon): validate fee ante decorator #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tbruyelle
changed the title
tbruyelle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #44
Warning: because the base branch doesn't exist in the origin repo, this PR couldn't used
tbruyelle/feat/photon-moduleas the base branch. The real diff can be seen here : tbruyelle/atomone@tbruyelle:atomone:tbruyelle/feat/photon-module...tbruyelle/feat/photon-tx-fee-checkerThis PR adds a
sdk.AnteDecoratorimplementation inx/photon/anteand adds it to the list of the app ante decorators. This new ante decorator ensures that photon is the fee token or returns an error. Exceptions are possible like if the transaction's messages type URL are present in a new parameter of the photon moduletxFeeExceptions.Some significant changes have been made to the e2e tests to make them compatible with this conditions.
uatonehas also been put in a constant to avoid repetition (inapp/paramspackage)