doc: ADR-002 The Photon Token #34
Conversation
There was a problem hiding this comment.
I have proposed some changes and given some initial feedback. Will come back to this with my own writeups after you give it another pass. But in general the groundwork is there. The design is simple enough as it should be.
We should also mention maybe the fact that photon will also be used for ICS payments, but that such an enforcement will be a burden of the ICS software, I think. Maybe not relevant to this module but relevant in clarifying the functionality of the photon token.
|
@giunatale Addressed your comments, except for the ICS part, I don't know yet where to put it, and since you're willing to come back with your own write-ups, I let you find the correct location to talk about this. Thanks for the review! |
|
@tbruyelle I pushed some changes, I think it's mostly ready for broader review. lmk your thoughs. |
The current TxFeeChecker does not check against *all* the denom listed in the validator minimum-gas-prices, but against *at least* one of the denom listed. So actually by listing both uatone and uphoton, we can use the same check in the photon TxFeeChecker, it will work whether photon is required or not. See `feeCoins.IsAnyGTE()` function.
First draft of the ADR to be reviewed.
I left a few comments for reviewers after the
XXXsymbol.Also updated the
adr-templatebecause it was using the windows file format.Rendered version