Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Comment in sql string breaks highlighting #418

Open
roblourens opened this issue Mar 8, 2021 · 1 comment
Open

Comment in sql string breaks highlighting #418

roblourens opened this issue Mar 8, 2021 · 1 comment

Comments

@roblourens
Copy link
Contributor

From microsoft/vscode#118450

Write following Code:

<?php

/*** GET ***/
$System->Router('DELETE /push/*', function ($self, $variables) {
    ...
});
$System->Router('GET /push', function ($self, $variables) {
    ...
});

Now you can see, that everything after /push/* will be handled as a comment in highlighting.

Similar to #187

@KapitanOczywisty
Copy link
Contributor

This shouldn't be treated as SQL, we might add some filtering to check the next word after DELETE to remove some false-positives. Second thing is this endless battle with embedded syntaxes, where nobody wants to touch TextMate syntax - this should be improved a long time ago..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants