Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Test Cases? #38

Closed
oakmac opened this issue Feb 23, 2016 · 4 comments
Closed

Test Cases? #38

oakmac opened this issue Feb 23, 2016 · 4 comments

Comments

@oakmac
Copy link

oakmac commented Feb 23, 2016

Are there are any tests for this package?

Looking at some of the open Issues #23, #32, #33, #35 - it would be nice to develop some expected test cases for these and ensure functionality moving forward.

I suppose a more general question is: are there test cases for any grammar package in Atom?

@winstliu
Copy link
Contributor

are there test cases for any grammar package in Atom?

Yes, most languages have somewhat decent spec coverage by now. Some leaders in the field are language-javascript, language-go, and language-c.

This package also has tests, but unfortunately the only test right now is to make sure the grammar loads...https://github.com/atom/language-clojure/blob/master/spec/grammar-spec.coffee.

(Also, the autoindent issues are much, much harder to solve than normal syntax highlighting ones, as they require knowledge of both the language and the arcane and barely working autoindent regexes).

If you'd like to take a stab at writing some specs, please feel free to! I'd love to help you along if necessary.

@oakmac
Copy link
Author

oakmac commented Feb 23, 2016

Thanks for the response! I'm tempted to dig into this a bit further.

Also, the autoindent issues are much, much harder to solve than normal syntax highlighting ones, as they require knowledge of both the language and the arcane and barely working autoindent regexes

Where are those autoindent regexes located?

@winstliu
Copy link
Contributor

language-clojure doesn't even have any auto-indent regexes, heh. You can find an example of them here though: https://github.com/atom/language-go/blob/master/settings/language-go.cson
With a general auto-indent rewrite in progress at atom/atom#10384.

@oakmac
Copy link
Author

oakmac commented Feb 23, 2016

Very helpful; thank you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants