From 6a52e6d644db95c855b621d4595a6b4fff50c395 Mon Sep 17 00:00:00 2001 From: Michal Wyrzykowski Date: Thu, 13 Feb 2020 08:25:31 +0100 Subject: [PATCH] NONE: Clarify pull request rules --- CONTRIBUTING.md | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 72ed8f7..eca2dbf 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,18 +11,31 @@ You can build and run virtual users on MacOS, Windows or Linux. You'll need JDK ## Submitting changes -Pull requests, issues and comments are welcome. For pull requests: +Pull requests, issues and comments are welcome. Below checklist can help you to go smoothly through the review. +Please remember that common sense applies here. + +### Pull Request Readiness readiness checklist + + * [ ] Includes tests to exercise the new behavior and bugs. + * [ ] Follows the existing style. + * [ ] Git commit message is detailed and includes context behind the change. + * [ ] If the change is related to an existing Bug Report or Feature Request, + the issue number is referenced + * [ ] For bigger changes, make sure you start a discussion first by creating + an issue and explaining the intended + change. - - Add tests for new features and bug fixes - - Follow the existing style - - Separate unrelated changes into multiple pull requests - See the [existing issues](https://ecosystem.atlassian.net/projects/JPERF/issues/?filter=allissues) for things to start contributing. +## Getting Your Pull Request Merged + +All Pull Requests must be approved by at least one member of the @atlassian/jpt team +before it can be merged in. + For bigger changes, make sure you start a discussion first by creating an issue and explaining the intended change. -All the pull requests and other changes will be accepted and merged by Atlassians. +### Legal requirements Atlassian requires contributors to sign a Contributor License Agreement, known as a CLA. This serves as a record stating that the contributor is