-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSR without document is breaking during initialising the module #52
Comments
I think JSDOM is currently still a hard requirement |
For router, I think it's better remove that dependency for server bundle, since it's not a hard requirement for router here. |
IMO, a separate |
That's is the best way to distinguish node and browser 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I have been playing around with the latest router version, it seemed like when this router is running in Node.js environment without document supplied, it will try to access a global
document
:https://github.com/atlassian-labs/react-resource-router/blob/master/src/common/constants.ts#L18
The text was updated successfully, but these errors were encountered: