New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observer] Use ControllerRevision owner OwnerReferences to match to Daemonset #26

Open

Jacobious52 opened this issue Jan 19, 2021 · 0 comments

Labels

enhancement good first issue

Collaborator

Jacobious52 commented Jan 19, 2021

Currently ControllerRevision is matched to Daemonset with Label Selector. ControllerRevision now has OwnerReferences like Pods.

  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: DaemonSet
    name: ds-name
    uid: 9eb7d74c-efc7-44aa-83c9-b61ec7626471

This should simply the ControllerRevision to Daemonset mapping and remove the potential of error using labels.

We currently do this for Pods so we can easily migrate the existing functionality to ControllerRevision as well.

Jacobious52 added enhancement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment