-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0,CLOSED\r\n
is ignored by URC parser
#15
Comments
First of all, thanks for bringing this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #13: I am observing the issue that
0,CLOSED\r\n
is missed. (After manually closing a TCP connection from the other side.) My report is here: FactbirdHQ/atat#184 (comment). In short, it's about\r\nSEND OK\r\n0,CLOSED\r\n
. Where theSEND OK
is processed, but0,CLOSED
is not as it is discarded as 'echo or whitespace'.This was observed by using
atat
v0.20.0, using async, and hooking up theURCMessages
from this library.I am not 100% sure whether this is a bug in
atat
or in the URC parser.As #13 was fixed in this library, I'm curious to know if there's any solution on the parser side.
The text was updated successfully, but these errors were encountered: