Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add readme for testing suite #2085

Closed
wants to merge 27 commits into from

Conversation

reachaadrika
Copy link
Contributor

Description
I have worked on creating the complete testing suite of Website using Cypress , it shall be helpful for both the contributors and maintainers to know how the tests are run and the folder structure so that if any new tests have to be added to the website or existing tests are to be changed it becomes easy for them to navigate and run the tests locally .

Related issue(s)
fixes #2084

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 38f70c2
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6697fddb81797e0008520253

@reachaadrika
Copy link
Contributor Author

cc : @akshatnema @derberg @alequetzalli 🚀

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 23
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-2085--asyncapi-website.netlify.app/

@akshatnema akshatnema added the gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code label Aug 22, 2023
-It utilises [Cypress/react] to provide some additional functionalites to Cypress .

## Requirements
Use the following tools to set up the project:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the command to do npm install with correct npm version and run cypress with appropriate Node version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reachaadrika This comment is not addressed.


This folder contains the test code of AsyncAPI website :

- It 's powered by [Cypress](https://docs.cypress.io/guides/overview/why-cypress) ,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a short description about Cypress, Component testing and E2E testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

├── test # Source for the entire testing suite
├── utils # Necessary Reusable Code and components for writing tests.
file
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a step on how to add tests inside the cypress folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

```text
├── downloads # Any necessary downloads for the tests
├── fixtures # Stores all the mock data files used in various tests
├── plugins # Used to create additional functionalities in Cypress(if required)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
├── plugins # Used to create additional functionalities in Cypress(if required)
├── plugins # Used to create additional functionalities in Cypress(if required)

cypress/README.md Outdated Show resolved Hide resolved
├── downloads # Any necessary downloads for the tests
├── fixtures # Stores all the mock data files used in various tests
├── plugins # Used to create additional functionalities in Cypress(if required)
├── support # Main skeleton for the Cypress tests , Custom commands can be added here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
├── support # Main skeleton for the Cypress tests , Custom commands can be added here
├── support # Main skeleton for the Cypress tests. Custom commands can be added here


This folder contains the test code of AsyncAPI website :

- It 's powered by [Cypress](https://docs.cypress.io/guides/overview/why-cypress) ,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- It 's powered by [Cypress](https://docs.cypress.io/guides/overview/why-cypress) ,
- It's powered by [Cypress](https://docs.cypress.io/guides/overview/why-cypress).


- It 's powered by [Cypress](https://docs.cypress.io/guides/overview/why-cypress) ,

-It utilises [Cypress/react] to provide some additional functionalites to Cypress .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-It utilises [Cypress/react] to provide some additional functionalites to Cypress .
- It utilises [Cypress/react] to provide additional functionalities to Cypress.

cypress/README.md Outdated Show resolved Hide resolved

## Run tests locally

Assuming you have all the necessary website dependencies installed :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Assuming you have all the necessary website dependencies installed :
Assuming you have all the necessary website dependencies installed:

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some fixes left to make :)

@derberg derberg changed the title docs: adding readme for testing suite docs: add readme for testing suite Aug 30, 2023

1. Run it and check on the Cypress Graphical User Interface
```bash
npm cypress open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the latest changes in master branch, it should be npm run cy:open.


2. Add tests in the respective testing folder :
For eg : Include tests for "scripts" in the scripts folder .
For creating a new component , create a new folder with the same name as component is named in the code .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to create a new folder to add a test for a component. It can be a separate file. Important point here is to follow same directory inside test folder, as the same file inside the root of the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I am reading in this thread, it looks like @reachaadrika has yet to address this feedback from @akshatnema. This section still seems to have incorrect information suggesting one must open a new folder to add a test for a component.

@akshatnema
Copy link
Member

@alequetzalli Ping Pong for the review 😅

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Feb 28, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2085--asyncapi-website.netlify.app/

cypress/README.md Outdated Show resolved Hide resolved
@quetzalliwrites
Copy link
Member

@AnimeshKumar923 @akshatnema I can't review this because the creator of the PR has not addressed all feedback; once they finish addressing all feedback, this PR can move to next stage.

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reachaadrika Are you still around? It looks like folks like your doc but they are waiting for you to address feedback.

@akshatnema
Copy link
Member

@alequetzalli
I'll take a look at this PR now. The author has become inactive in the org, so I will be making changes on behalf of her.

Do review the PR fully, so that I could make the changes at the once.

@github-actions github-actions bot removed the stale label Feb 29, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 11, 2024
@sambhavgupta0705
Copy link
Member

Still relevant '

@github-actions github-actions bot removed the stale label Jul 16, 2024
@sambhavgupta0705
Copy link
Member

/update

@sambhavgupta0705
Copy link
Member

closing this as we don't require this fix now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: Add additional ReadMe for testing suite of the website
6 participants