Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Codecov action is failing with error Token required because branch is protected on some PRs #3469

Open
2 tasks done
anshgoyalevil opened this issue Dec 14, 2024 · 1 comment · May be fixed by #3470
Open
2 tasks done

[BUG] Codecov action is failing with error Token required because branch is protected on some PRs #3469

anshgoyalevil opened this issue Dec 14, 2024 · 1 comment · May be fixed by #3470
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug good first issue Good for newcomers

Comments

@anshgoyalevil
Copy link
Member

Describe the bug.

Codecov action is failing with the error Token required because branch is protected

Example run: https://github.com/asyncapi/website/actions/runs/12325955821/job/34406096966?pr=3463#step:16:75

Reported issue on Codecov official repo:
codecov/codecov-action#1580

Expected behavior

It should pass.

Screenshots

NA

How to Reproduce

Can't really reproduce intentionally.

🥦 Browser

None

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None
@anshgoyalevil
Copy link
Member Author

anshgoyalevil commented Dec 14, 2024 •
edited
Loading

The possible fix is to bump the version of Codecov from v4 to v5. This required changing the following line.

website/.github/workflows/if-nodejs-pr-testing.yml

Line 120 in 0349217

uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 

- uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673
+ uses: codecov/codecov-action@7f8b4b4bde536c465e797be725718b88c5d95e0e

as suggested in zigpy/workflows#26

@anshgoyalevil anshgoyalevil added area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Dec 14, 2024
@anshgoyalevil anshgoyalevil linked a pull request Dec 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump codecov from v4 to v5 anshgoyalevil/website
1 participant
@anshgoyalevil