Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit concurrency in markdown file processing to improve performance #3429

Open
coderabbitai bot opened this issue Nov 25, 2024 · 5 comments
Open

Limit concurrency in markdown file processing to improve performance #3429

coderabbitai bot opened this issue Nov 25, 2024 · 5 comments
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/javascript area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.

Comments

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2024

This issue aims to address the need for limiting concurrency in processing markdown files to improve performance and prevent potential resource exhaustion.

Currently, scripts/markdown/check-markdown.js processes markdown files asynchronously without a concurrency limit, which could lead to too many open file handles and impact system resources.

As discussed in PR #3378 and the related comment, it's important to implement concurrency control in the script.

Assigning to @akshatnema for further action.

@sambhavgupta0705
Copy link
Member

@Aditya0732 and @Sarvesh2783
You both have opened PR for this ,if you both can tell your approach here so that we can decide with whom we should go forward

@Aditya0732
Copy link

@Aditya0732 and @Sarvesh2783 You both have opened PR for this ,if you both can tell your approach here so that we can decide with whom we should go forward

Hey @sambhavgupta0705, have added a detailed PR #3481 please check and let me know.

@anshgoyalevil anshgoyalevil added area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/javascript labels Dec 26, 2024
@29deepanshutyagi
Copy link

i want to work on this issue , if it's open to contribute , kindly assign me @akshatnema

@sambhavgupta0705
Copy link
Member

@29deepanshutyagi you may work on this one

@ChaitanyaKadu03
Copy link

Hello @anshgoyalevil @akshatnema @shubhamku044 @Shurtu-gal,

I’d like to work on Issue #3429 regarding limiting concurrency in markdown file processing to improve performance and prevent resource exhaustion.

Request for Assignment

  • Could you please assign this issue to me? My plan is to:
    1. Implement concurrency control using "p-limit".
    2. Create test cases to verify concurrency limits and error handling.
    3. Address any code review feedback to ensure a smooth merge.

I look forward to contributing. Let me know if you need more information before I begin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/javascript area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants