Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] algolia search icon not visible on website navbar #3371

Open
2 tasks done
anshgoyalevil opened this issue Nov 7, 2024 · 3 comments · May be fixed by #3400
Open
2 tasks done

[BUG] algolia search icon not visible on website navbar #3371

anshgoyalevil opened this issue Nov 7, 2024 · 3 comments · May be fixed by #3400
Labels
bug good first issue Good for newcomers

Comments

@anshgoyalevil
Copy link
Member

Describe the bug.

There used to be an Algolia Search Icon besides the Language Picker element on Navbar. It is no longer visible, though we can click it as it is present over there but is very small in size.

Expected behavior

image

In wireframe:

image

Screenshots

image

In wireframe:

image

(That circle besides the Language Picker is where the search icon used to be)

How to Reproduce

  • Visit AsyncAPI.com

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it
@anshgoyalevil anshgoyalevil added bug good first issue Good for newcomers and removed bug labels Nov 7, 2024
@amanbhoria
Copy link

amanbhoria commented Nov 7, 2024 •
edited
Loading

Hi @anshgoyalevil , I've looked into this issue and seems like IconLoupe component i.e Search icon is not rendered correctly as a children prop in AlgoliaSearch file.

  • initially children i.e. IconLoupe is not treated as a function but a React Node and that's obvious. But later it's treated as a function. I'm attaching a screenshot for the reference.

image

image

As soon as i do setChildren(children) the search bar appears on the homepage. If we've to fix this issue, we can do it that way.
But yes, we can't do this as we can't use the actionKey then.

These are my findings, thank you!

maverickf0 added a commit to maverickf0/website that referenced this issue Nov 7, 2024
@maverickf0
Fix: algolia search icon is visible (asyncapi#3371)
818ec69
@maverickf0
Copy link

@amanbhoria can't we just do this instead
image

it solves the issue

@amanbhoria
Copy link

@maverickf0 this seems to be working fine but I'm wondering how this issue occurred on the first place. I mean how this got merged in the master branch.

maverickf0 added a commit to maverickf0/website that referenced this issue Nov 7, 2024
@maverickf0
fix: algolia search icon is visible now (asyncapi#3371)
8f23baa
@amanbhoria amanbhoria mentioned this issue Nov 7, 2024
Open
jyotishpro added a commit to jyotishpro/asyncapi-website that referenced this issue Nov 16, 2024
@jyotishpro
fix visibily issue asyncapi#3371 with algolia search icon in navbar
117e2a2
@jyotishpro jyotishpro linked a pull request Nov 16, 2024 that will close this issue
Open
jyotishpro added a commit to jyotishpro/asyncapi-website that referenced this issue Nov 16, 2024
@jyotishpro
fixes asyncapi#3371 algolia search button for mobile
2cadadf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #3371 visibility issue with algolia search icon in navbar jyotishpro/asyncapi-website
3 participants
@amanbhoria @anshgoyalevil @maverickf0