Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] We can make a toggle on the side bar so that A reader can can go through with full screen and no Interruption. #3325

Closed
2 tasks done
mohdshubair313 opened this issue Oct 24, 2024 · 6 comments
Labels

Comments

@mohdshubair313
Copy link

Describe the bug.

when I come to the website there is not the full view of the docs so because of that the reader cannot reads the concepts and guides and can view all the content on full screen by click the toggle button.

Expected behavior

When the Toggle button clicked then the whole content hides and only icons are visible so that there is full view available for the content

Screenshots

Screenshot (256)

How to Reproduce

  1. open the website on the browser
  2. you see the sidebar but its does not have a toggle button to hidden the extra spaces for reading docs
  3. place a toggle button for easiness to read!

🥦 Browser

None

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@mohdshubair313
Copy link
Author

can I work on this issue @antoniogarrote

@lakshaydewan
Copy link

lakshaydewan commented Oct 25, 2024

@mohdshubair313 no one is assigned to issues u can just start working and submit PR and the maintainers will merge after reviewing.

@mohdshubair313
Copy link
Author

@lakshaydewan should I make a new branch or push code to master

@mohdshubair313
Copy link
Author

@antoniogarrote @akshatnema @MikeRalphson @scharrier please review my PR. I have made this PR as per the community guidelines

@anshgoyalevil
Copy link
Member

Closing this issue since there doesn't seems to be a need for this feature at the moment. Other popular documentation frameworks like Docusaurus doesn't offer such a functionality

@anshgoyalevil anshgoyalevil closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants