Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: vnk/fix websocket code snippet #2977

Conversation

VaishnaviNandakumar
Copy link
Collaborator

@VaishnaviNandakumar VaishnaviNandakumar commented May 19, 2024

Description
Updated code snippet in the websocket slackbot tutorial.

  • ...
  • ...
  • ...

Related issue(s)
Resolves #2946

Copy link

netlify bot commented May 19, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ba7e834
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6651416fe551d900087ab95c
😎 Deploy Preview https://deploy-preview-2977--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented May 19, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 30
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 56

Lighthouse ran on https://deploy-preview-2977--asyncapi-website.netlify.app/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaishnaviNandakumar Kindly remove the changes from this file. I think you did a mistake in resolving conflicts 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sorry. Careless mistake on my end, i've removed the file.

@quetzalliwrites quetzalliwrites changed the title Vnk/fix websocket code snippet docs: vnk/fix websocket code snippet May 21, 2024
@quetzalliwrites quetzalliwrites added 🐞 docs bug area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels May 21, 2024
@quetzalliwrites
Copy link
Member

Thank you so much, @VaishnaviNandakumar! ♥️ ♥️ ♥️

@quetzalliwrites
Copy link
Member

@akshatnema can you review again? 😸

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit a3bc647 into asyncapi:master May 25, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 🐞 docs bug ready-to-merge
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

[Docs] Feedback on /docs/tutorials/websocket - Thu, 21 Mar 2024 01:29:38 GMT
4 participants