-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve message.md #2966
docs: improve message.md #2966
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2966--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alequetzalli Do you need my help here? 😅 |
Hey @akshatnema, thank you for asking 😸 ... yes, I can't merge; still shows as "merging is blocked." Can you merge for me? |
@alequetzalli please make sure that you don't make feature branches inside the asyncapi/website repo. Instead make PRs from your forked repo only. Making feature branches in the repo can be quite confusing for other contributors as well and we only make feature branches if we need to spilt our feature changes into multiple PRs and do the testing of those changes in separate website preview (instead of doing it in production). |
Hey @akshatnema, wow, I didn't realize I had created a feature branch! 😄 Sorry about that, thanks for explaining my mistake. |
Resolves: #2934.