chore(migrate): migrate tools pages #2876
Conversation
Shurtu-gal
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@Shurtu-gal Can you change the CodeComponent such that the numbers appear same as they are in master?
Take the reference from this PR - #2867 |
asyncapi-bot
requested review from
BhaswatiRoy,
J0SAL,
octonawish-akcodes,
TRohit20 and
VaishnaviNandakumar
|
@akshatnema done |
components/editor/CodeBlock.tsx
Outdated
| padding: '0 0.5em', | ||
| background: isHighlighted ? '#252f3f' : 'inherit', | ||
| color: isHighlighted ? '#A3ACAD' : '#8B9394' |
There was a problem hiding this comment.
how you got these colors and properties? is this part of master branch?
There was a problem hiding this comment.
From
Lines 122 to 125 in 48cb678
There was a problem hiding this comment.
So, why it isn't taking color directly from tailwind?
components/buttons/GithubButton.tsx
Outdated
| @@ -18,7 +18,7 @@ interface IGithubButtonProps extends IButtonDefaultProps { | |||
| * @param {string} props.className - The class name to be applied to the button. | |||
| */ | |||
| export default function GithubButton({ | |||
| text = 'githubButton', | |||
| text = 'View on GitHub', | |||
There was a problem hiding this comment.
This needs to be githubButton for the translation string to work
|
Some changes required on
Some UI changes: There needs to be a space after
|
|
Sorry, my exams just ended today 🙏🏻. @akshatnema has solved the issue I suppose, or is there something I should be doing? |
|
/rtm |
Description
Related issue(s)
#2636