-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of docker #2164
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Dockerfile would make sense imho. I was recently introduced to https://code.visualstudio.com/docs/devcontainers/create-dev-container, maybe that would be best? in the end majority of fronend contributors use VSCode |
Yes indeed and docker helps a lot in frontend development as every now and then i see myself installing older version of node pnpm yarn for better installation and then setting up local database for better engagement with the interface and this can be handled with docker-compose file for setting up this environment with the least resource require! |
docker compose is not needed imho, we just need a dockerfile that will setup things. the most important is developer experience, how will one use docker image to locally build website, and develop and see results of development thus I was thinking that maybe dev container is easier to work with 🤔 |
@derberg I completely agree with you! To address how Docker can be beneficial for a better developer experience:
if you want me to work on this 😊😊 will be more than happy to contribute! |
and what is your opinion on VSCode and dev container? |
honestly i havent tried that but while going through the web i got to know it can work both ways either with there own image and configuration or by dockerfile. |
sounds good to me, but please do it in 2 separate PRs, one at a time. I guess best would be docker as first, as it is more universal |
Hey @derberg @captain-Akshay, after reading your discussion. I've couple of doubts here:
|
|
Reason/Context
It will help the developers to start the local development without installing the dependency make the development process faster and easy.This will certainly help the contributor to a great extent as docker provide containerization which will not affect there computer and reduce the trouble for running it locally.
Description
Just a Dockerfile would be enough for generating an image and running it locally but to take it even further we can make a docker-compose.yml as well to make it more easy to depoly locally.This will act individually so any problem with the docker container wont affect or interfere the work of nextjs application.
I can work on this !
The text was updated successfully, but these errors were encountered: